Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T376243 Preparing for next Wikibase and Deploy 1 release (don't merge) #806

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

darthmon
Copy link
Contributor

@darthmon darthmon commented Nov 18, 2024

Changes relevant versions for wikibase and deploy.

Remaining tasks:

  • Update versions (1.0.2 for Wikibase, and 3.0.3 for Deploy?)
  • Create appropriate CHANGELOG for Wikibase and Deploy. Look to existing 3.x build/wikibase/CHANGELOG.md and deploy/CHANGELOG.md still in this branch for source

@darthmon
Copy link
Contributor Author

Note for release: we need to include in the changelogs an (manual) entry with a link to the changes that come from Deploy 3.0.3 that are added in this release (https://github.com/wmde/wikibase-release-pipeline/blob/main/deploy/CHANGELOG.md)

@rti
Copy link
Contributor

rti commented Nov 25, 2024

If I am not mistaken, this PR is missing the change of the actual MW version. It is still referencing 1.42 https://github.com/wmde/wikibase-release-pipeline/pull/806/files#diff-afdda425857a52631f6ea8939ad5e33fa3b8c9c05c1a37eb36a4ba78f6d9db20L8

Testing whether 1.39.10 works was also done here #781

@lorenjohnson
Copy link
Contributor

If I am not mistaken, this PR is missing the change of the actual MW version. It is still referencing 1.42 https://github.com/wmde/wikibase-release-pipeline/pull/806/files#diff-afdda425857a52631f6ea8939ad5e33fa3b8c9c05c1a37eb36a4ba78f6d9db20L8

Testing whether 1.39.10 works was also done here #781

Oh that's terrible, and you're entirely correct. I've re-created the release with MEDIAWIKI_VERSION appropriately updated, and then re-ran ./nx update-commits wikibase. Things should be in the correct state now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants