Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback for error handling #96

Draft
wants to merge 2 commits into
base: fixErrors
Choose a base branch
from
Draft

Conversation

C-Loftus
Copy link
Collaborator

@C-Loftus C-Loftus commented Dec 8, 2024

  • type the t function so there is intellisense and build errors if it is called with a message that doesnt exist in the locales
  • test the t function and the locale json files to make sure all locales have the same key names
  • Change the message when there are no discovery datasets
  • Check caching issues with nginx
    • (I think this is coming from a difference in the backend now, not the frontend)
  • Add machine translation strings for each of the locales for the new error message

Unfinished. Will merge into #95 once finished (and then we can merge that into main), but separated for easier review

@C-Loftus C-Loftus marked this pull request as draft December 8, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant