-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge country and centre-id #570
Conversation
c020ff0
to
ae8547f
Compare
ae8547f
to
6499224
Compare
6499224
to
975ab90
Compare
975ab90
to
1ac5c1f
Compare
TODO: update relevant screenshots (@maaikelimper) |
3726498
to
42ef9d5
Compare
@tomkralidis Could we please add some clarification on choosing the correct center-id in the documentation here: wis2box/docs/source/user/setup.rst Lines 45 to 46 in 31e57b8
Should the wis2box-create-config.py include a check that ensures the user provides a valid TLD prefix ? |
Note: we are keeping As for guidance on centre id selection, suggest we defer until the WIS2 Guide is approved. Having said this, I've pushed a small doc update to help clarify in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, approved.
I will prepare a separate PR to update wis2box-create-config.py and countries.json
Fixes #562
Fixes #576
Note: we are keeping
country
in the MCFwis2box
object, mostly as a means to help users pre-select their country to derive a related bounding box. If https://github.com/wmo-im/wis2box/blob/main/config-templates/countries.json is updated to be based on TLD (and not ISO 3166-3), then we can removecountry
entirely from the wis2box workflow (this can be part of another PR).