Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge country and centre-id #570

Merged
merged 5 commits into from
Nov 24, 2023
Merged

merge country and centre-id #570

merged 5 commits into from
Nov 24, 2023

Conversation

tomkralidis
Copy link
Collaborator

@tomkralidis tomkralidis commented Nov 14, 2023

Fixes #562

Fixes #576

Note: we are keeping country in the MCF wis2box object, mostly as a means to help users pre-select their country to derive a related bounding box. If https://github.com/wmo-im/wis2box/blob/main/config-templates/countries.json is updated to be based on TLD (and not ISO 3166-3), then we can remove country entirely from the wis2box workflow (this can be part of another PR).

@tomkralidis tomkralidis added this to the sprint-013 milestone Nov 14, 2023
@tomkralidis tomkralidis changed the title [WIP ] merge country and centre-id [WIP] merge country and centre-id Nov 14, 2023
@tomkralidis tomkralidis changed the title [WIP] merge country and centre-id merge country and centre-id Nov 21, 2023
@tomkralidis tomkralidis added enhancement New feature or request topic-hierarchy labels Nov 22, 2023
@tomkralidis
Copy link
Collaborator Author

TODO: update relevant screenshots (@maaikelimper)

@maaikelimper
Copy link
Collaborator

@tomkralidis Could we please add some clarification on choosing the correct center-id in the documentation here:

The script will ask for 3-letter ISO country code for your wis2box. Please provide the 3-letter ISO country code for your country, for example ``FRA``.
It will also ask for a centre-id. Please provide a string that identifies your organization and does not use spaces or special characters, for example ``meteofrance``.

Should the wis2box-create-config.py include a check that ensures the user provides a valid TLD prefix ?

@tomkralidis
Copy link
Collaborator Author

Note: we are keeping country in the MCF wis2box object, mostly as a means to help users pre-select their country to derive a related bounding box. If https://github.com/wmo-im/wis2box/blob/main/config-templates/countries.json is updated to be based on TLD (and not ISO 3166-3), then we can remove country entirely from the wis2box workflow (this can be part of another PR).

As for guidance on centre id selection, suggest we defer until the WIS2 Guide is approved.

Having said this, I've pushed a small doc update to help clarify in the meantime.

Copy link
Collaborator

@maaikelimper maaikelimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, approved.

I will prepare a separate PR to update wis2box-create-config.py and countries.json

@tomkralidis tomkralidis merged commit 0619c57 into main Nov 24, 2023
3 checks passed
@tomkralidis tomkralidis deleted the issue-562-centre-id branch November 24, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic-hierarchy
Projects
None yet
2 participants