Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helgrind thread errors with enable-tls, and enable-curl. #395

Closed
wants to merge 1 commit into from

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Feb 7, 2024

Fix Helgrind thread errors around simultaneous reads and writes from different threads:

  • Simultaneous read and write with WOLFSSL struct.
  • Simultaneous read and write with CURL handle.
  • Separate tls.timeout_ms member into separate tls.timeout_ms_read and tls.timeout_ms_write members to prevent simultaneous assignment or overwriting.
  • Separate mqttcurl_test_nonblock() into separate read and write functions to fix simultaneous updates from different read/write threads.

@philljj philljj self-assigned this Feb 7, 2024
@philljj philljj force-pushed the fix_threading_issues branch from 9463635 to 5320996 Compare February 8, 2024 08:15
@philljj
Copy link
Contributor Author

philljj commented Feb 16, 2024

This passes locally but fails in CI. I think this has something brittle.

@philljj philljj requested a review from dgarske February 16, 2024 20:19
@philljj philljj closed this Feb 28, 2024
@philljj philljj deleted the fix_threading_issues branch March 1, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant