Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term Update #585

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Term Update #585

merged 1 commit into from
Sep 19, 2023

Conversation

ejohnstown
Copy link
Contributor

  1. Change GetTerminalSize() to GetTerminalInfo().
  2. Add the term variable to the things GetTerminalInfo() looks up.
  3. Return the actual value of the environment variable TERM to the server. If one isn't present, default to "xterm".
  4. Clean up the whitespace in SendChannelTerminalRequest().

Misc other changes:

  1. Cleanup whitespace in the recently added function SendChannelOpenFail().
  2. Add labels to the parameters in the prototype for SendChannelOpenFail().
  3. Remove the CR addition for Windows in the example client. Causes the enter key to double-strike.

Testing

% echo $TERM
% ./examples/client/client -u username -i ~/.ssh/id_ecdsa -j ~/.ssh/id_ecdsa.pub -p 22 -t -h server
% echo $TERM

The TERM values should match. Before the change, the server will always be told "xterm". On my system TERM is set to "screen-256color". The noticeable difference I had was with vim. Before the fix, vim would be in black-and-white. With the fix it is full color.

1. Change GetTerminalSize() to GetTerminalInfo().
2. Add the term variable to the things GetTerminalInfo() looks up.
3. Return the actual value of the environment variable TERM to the
   server. If one isn't present, default to "xterm".
4. Clean up the whitespace in SendChannelTerminalRequest().

Misc other changes:
1. Cleanup whitespace in the recently added function
   SendChannelOpenFail().
2. Add labels to the parameters in the prototype for
   SendChannelOpenFail().
3. Remove the CR addition for Windows in the example client. Causes the
   enter key to double-strike.
@dgarske dgarske merged commit 74ca716 into wolfSSL:master Sep 19, 2023
2 checks passed
@ejohnstown ejohnstown deleted the term branch September 19, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants