RSA Verify Check #634
Merged
RSA Verify Check #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added function wolfSSH_RsaVerify() which verifies the provided RSA signature with the provided key. 2. Call wolfSSH_RsaVerify() after all calls to wc_RsaSSL_Sign(). 3. Changed a comparison between an unsigned and 0 to == from <=. 4. Fixed a spot where we still tried to sign a digest when the call to wc_DigestFinal() failed.
ejohnstown
force-pushed
the
rsa-check
branch
from
d75011e to
b97b6c7
Compare
JacobBarthelmeh
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential but unconfirmed vulnerability in wolfSSH described in the paper "Passive SSH Key Compromise via Lattices" by Keegan Ryan, et al, at UCSD.