Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate PrivBeginPrefix/PrivSuffix; init typeSz in ssh.c #641

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

gojimmypi
Copy link
Contributor

@gojimmypi gojimmypi commented Dec 28, 2023

The PrivBeginPrefix and PrivSuffix are only used in wolfSSH_ReadKey_file() which is gated with:

#if !defined(NO_FILESYSTEM) && !defined(WOLFSSH_USER_FILESYSTEM)

... thus otherwise there's a compiler warning about them not being used on a no-filesystem target.

There's also a typeSz = 0 initialization that was failing as the Espressif compiler was complaining it was not initialized.

@gojimmypi gojimmypi changed the title gate PrivBeginPrefix/PrivSuffix; init typeSz in ssh.c Gate PrivBeginPrefix/PrivSuffix; init typeSz in ssh.c Dec 28, 2023
@ejohnstown ejohnstown merged commit b6889cb into wolfSSL:master Jan 11, 2024
10 checks passed
@gojimmypi gojimmypi deleted the PR-ssh-minor-updates branch July 22, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants