Certificate OK #669
Merged
Certificate OK #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Split ParseAndVerifyCert() into ParseCertChainVerify() and ParseCert() with a common ParseCertChain() function. 2. When the server is checking the user's certificate, don't do the verify step. Verify when the user's client sends a signature. The server needs to tell the client the cert is OK as a cert. Make the client do a PK sign. 3. If the certificate check fails, we still need to be able to send the failure message to the peer. Set the `ret` value back to `WS_SUCCESS`. All other auth actions are gated on the `authFailed`. 4. Whitespace. (ZD 17555)
douzzer
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retvalue back toWS_SUCCESS. All other auth actions are gated on theauthFailed.(ZD 17555)