Add Ed25519 #689
Merged
Add Ed25519 #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added support for Ed25519 private keys. 2. Added more define guards for ED25519 3. The userAuthResultCb must be invoked only in the case the pubkey has a signature. 4. Define WOLFSSH_NO_ED25519 if the ssh-ed25519 pubkey support must not be compiled for lack of prerequisites.
1. Whitespace fixes. 2. Refactor the signing KEX message signing to break the signing into functions depending on the key type.
1. Remove some redundant (and incorrect) scaffolding for a couple algorithms. 2. Whitespace fixes and add some braces to if-else blocks. 3. Fix allocating an ed25519 key, instead of using an ecc_key for it. 4. Replace a crypto failure error with an invalid algo error.
1. Add testing key for user barney. 2. Remove some instances of the incorrect macro guard WOLFSSH_NO_ECC. We deal in ECDSA or ECDHE separately only. 3. Add WIP function for decoding the OpenSSH format Ed25519 key.
1. Add an error code for Ed25519 signing or verify issues. 2. Add Ed25519 key support to ReadKey. 3. Add client side support for Ed25519. 4. Update some key usage log strings to be more descriptive.
dgarske
approved these changes
May 15, 2024
There was a problem hiding this comment.
@JacobBarthelmeh please review and finalize. Thanks John, lots of great work here!
JacobBarthelmeh
approved these changes
May 15, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
Add Ed25519
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
Add Ed25519
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Add Ed25519
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Add Ed25519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ED25519 server authentication and user authentication.
Supersedes PR #555.