ReadDir Override #691
Merged
ReadDir Override #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make wolfSSH_SFTPNAME_readdir defining SFTP_Name_readdir. It has to be
defined as a macro, but it can be defined to expand to its own name if
also a function with the same name is defined.
What matters is that it takes 3 arguments:
1) the filesystem context as first argument;
2) WDIR* as second argument;
3) WS_SFTPNAME* as third argument
On successful execution, it returns WS_SUCCESS and the WS_SFTPNAME
structure pointed by the third argument will be filled with the
relevant info, otherwise a WS_* error code is returned.
1. Whitespace. Reflow some comments. 2. Remove some redundant "TODO" comments.
dgarske
approved these changes
May 15, 2024
JacobBarthelmeh
approved these changes
May 15, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
ReadDir Override
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
ReadDir Override
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
ReadDir Override
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
ReadDir Override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make wolfSSH_SFTPNAME_readdir defining SFTP_Name_readdir. It has to be defined as a macro, but it can be defined to expand to its own name if also a function with the same name is defined.
What matters is that it takes 3 arguments:
On successful execution, it returns WS_SUCCESS and the WS_SFTPNAME structure pointed by the third argument will be filled with the relevant info, otherwise a WS_* error code is returned.
This supersedes PR #552.