OS Check Test #696
Merged
OS Check Test #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ejohnstown
commented
May 17, 2024
•
ejohnstown
commented
- Add a new test that checks both macOS and Ubuntu in one test, rather than as two separate tests.
- Remove the old ubuntu and macos tests.
- Update the kyber test to use similar cache naming as the os-check test.
1. Add a new test that checks both macOS and Ubuntu in one test, rather than as two separate tests. 2. Remove the old ubuntu and macos tests.
1. Change kyber test to use the cache naming in the other test. 2. Remove moving wolfSSL to another directory. Clears a bunch of warnings. 3. Build liboqs to install in the same directory as wolfSSL.
dgarske
approved these changes
May 20, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
OS Check Test
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
OS Check Test
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
OS Check Test
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
OS Check Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.