Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled #698

Merged
merged 1 commit into from
May 30, 2024
Merged

Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled #698

merged 1 commit into from
May 30, 2024

Conversation

miyazakh
Copy link
Contributor

sha1 is only enabled when user intentionally enables NO_SHA1_SOFT_DISABLE

ZD#17793

@dgarske dgarske changed the title Enable sha1 when NO_SHA1_SOFT_DISBALE is enabled Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled May 23, 2024
@JacobBarthelmeh
Copy link
Contributor

@miyazakh can I have some background on this, what was the commands used to test it? Did you test that the soft enable of sha1 still works as expected after the change?

@miyazakh
Copy link
Contributor Author

miyazakh commented May 29, 2024 •
edited
Loading

Hi @JacobBarthelmeh
Sorry for being the late input. This becomes failure when accessing OpenSSH when its version is less than 8.x under using public key client authentication. I am seeing OpenSSH_8.2p1 Ubuntu-4ubuntu0.11
.

Regarding the soft enable of sha1, I am going to check it again.

@dgarske dgarske requested a review from JacobBarthelmeh May 29, 2024 16:41
ejohnstown
ejohnstown approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@ejohnstown ejohnstown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this. I also have a branch where I fixed this the same exact way and forgot to follow up with a PR.

@JacobBarthelmeh JacobBarthelmeh merged commit d09e00a into wolfSSL:master May 30, 2024
24 checks passed
@miyazakh miyazakh deleted the sha1_softdisable branch June 2, 2024 07:06
jefferyq2 pushed a commit to jefferyq2/wolfssh that referenced this pull request Sep 24, 2024
@JacobBarthelmeh @jefferyq2
Merge pull request wolfSSL#698 from miyazakh/sha1_softdisable
c36c270 
Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled
jefferyq2 pushed a commit to jefferyq2/wolfssh that referenced this pull request Oct 18, 2024
@JacobBarthelmeh @jefferyq2
Merge pull request wolfSSL#698 from miyazakh/sha1_softdisable
83973ce 
Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled
jefferyq2 pushed a commit to jefferyq2/wolfssh that referenced this pull request Oct 29, 2024
@JacobBarthelmeh @jefferyq2
Merge pull request wolfSSL#698 from miyazakh/sha1_softdisable
40dc05e 
Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled
jefferyq2 pushed a commit to jefferyq2/wolfssh that referenced this pull request Oct 29, 2024
@JacobBarthelmeh @jefferyq2
Merge pull request wolfSSL#698 from miyazakh/sha1_softdisable
091f343 
Enable sha1 when WOLFSSH_NO_SHA1_SOFT_DISABLE is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes

@dgarske dgarske dgarske approved these changes

@ejohnstown ejohnstown ejohnstown approved these changes

Assignees

@JacobBarthelmeh JacobBarthelmeh

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miyazakh @JacobBarthelmeh @ejohnstown @dgarske @wolfSSL-Bot