-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
append git version info during Espressif install #5955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that none of the ESP-IDF stuff gets included with make dist
?
The include.am only has these three files:
EXTRA_DIST+= IDE/Espressif/ESP-IDF/setup_win.bat
EXTRA_DIST+= IDE/Espressif/ESP-IDF/dummy_test_paths.h
EXTRA_DIST+= IDE/Espressif/ESP-IDF/compileAllExamples.sh
I've converted this to a draft to consider other options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that might be useful for the entire project not just Espressif?
I would definitely like to see version information everywhere. If it were up to me, I'd have date/version info in each source file. Admittedly this PR modifying source code is a little wonky. Thanks @douzzer for the makefile idea as implemented for Espressif in #6018 If everyone likes the idea, I'll create a new PR that includes runtime display in version.h |
Can one of the admins verify this patch? |
As #6018 was merged, I think it is a better idea to have a more soft version detection, something other than modification of source files. See the Here's an example of displaying those values at runtime in the Espressif embedded environment:
|
Description
As noted in #5948 (comment) there can be several Espressif wolfSSL component installs in multiple directories for various ESP-IDF versions.
As the installation is a file copy process, the GitHub version information is currently lost at install time. The user at runtime only has the
LIBWOLFSSL_VERSION_STRING
andLIBWOLFSSL_VERSION_HEX
release values available.This update will add a few
#DEFINE
values to the installed component wolfsslversion.h
file such as:The Espressif
./setup.sh
now exists with a value of0
instead of1
if all was successful.Fixes zd# n/a
Testing
Run the
./setup.sh
for Espressif component install as explained in the Setup for Linux and observe the update toversion.h
as noted in the output.The command can also be run manually as desired:
resulting in this example output:
Windows install does not yet have this feature at this time. WSL can be used as a substitute.
Checklist