Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WOLFSSL_SHA_CTX for OpenSSL w/Espressif HW hash #6121

Closed

Conversation

gojimmypi
Copy link
Contributor

Description

This PR takes into account the size of the WC_ESP32SHA struct that is added to the wolfSSL WOLFSSL_SHA_CTX struct for the openSSL holder[] in openssl/sha.h for the Espressif ESP-IDF, fixing #6028.

Note that there are currently other errors when enabling OpenSSL and hardware acceleration on the ESP32, specifically the SHA224 failure noted in #6059 as well as SHA512/224 noted in #6028 (comment). I have a fix for those as well, but the days have turned into weeks for my major update in my ED25519_SHA2_fix branch, so I'm creating this separate PR now to address this specific compile issue.

Fixes zd# n/a

Testing

Successful benchmark and wolfssl_test when See #6028 (comment)

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi gojimmypi requested a review from dgarske February 22, 2023 15:54
@gojimmypi gojimmypi self-assigned this Feb 22, 2023
@dgarske dgarske self-assigned this Feb 22, 2023
@dgarske dgarske closed this Feb 22, 2023
@gojimmypi
Copy link
Contributor Author

@dgarske although the #5938 update certainly looked like it would have addresses this issue, it did not.

The sizeof(WC_ESP32SHA) continues to be problematic as noted in 3223fa9.

I'm reopening this issue with the same change suggestion.

To see the error, turn on #define OPENSSL_EXTRA for the ESP32. The error itself is manifested in ssl.c:

image

@gojimmypi
Copy link
Contributor Author

ah, apparently once I squash/merged my upstream, I can no longer reopen this issue:

image

I'll create a fresh PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants