Add MSYS2 build CI test #6932
Closed
Add MSYS2 build CI test #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lealem47
force-pushed
the
msys2
branch
6 times, most recently
from
ff0c553 to
67b75f1
Compare
lealem47
force-pushed
the
msys2
branch
2 times, most recently
from
f0692ab to
246438b
Compare
added 2 commits
May 16, 2024 09:22
dgarske
requested changes
May 16, 2024
| @@ -7457,7 +7463,7 @@ static THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args) | |||
| static THREAD_RETURN WOLFSSL_THREAD test_server_loop(void* args) | |||
| { | |||
| SOCKET_T sockfd; | |||
| SOCKET_T clientfd = -1; | |||
| SOCKET_T clientfd; | |||
There was a problem hiding this comment.
Usually we use SOCKET_INVALID.
| @@ -581,6 +581,12 @@ static int testDevId = INVALID_DEVID; | |||
| #define HAVE_SSL_MEMIO_TESTS_DEPENDENCIES | |||
| #endif | |||
|
|
|||
| #ifdef USE_WINDOWS_API | |||
There was a problem hiding this comment.
Seems unnecessary. Either case should be happy with (char*)
| @@ -7472,6 +7478,7 @@ static THREAD_RETURN WOLFSSL_THREAD test_server_loop(void* args) | |||
| func_args* opts = (func_args*)args; | |||
| int loop_count = opts->argc; | |||
| int count = 0; | |||
| int freeClientfd = 0; | |||
| @@ -7638,7 +7646,7 @@ static THREAD_RETURN WOLFSSL_THREAD test_server_loop(void* args) | |||
| if (!sharedCtx) | |||
| wolfSSL_CTX_free(ctx); | |||
|
|
|||
| if (clientfd >= 0) | |||
| if (freeClientfd) | |||
There was a problem hiding this comment.
clientFd != SOCKET_INVALID
|
Closing this. Being handled in #8367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add MSYS2 build CI github actions test
Checklist