-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Espressif wolfcrypt updates #7035
Espressif wolfcrypt updates #7035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
wolfssl/wolfcrypt/settings.h
Outdated
#if defined(NO_ESP32WROOM32_CRYPT) | ||
#undef NO_ESP32WROOM32_CRYPT | ||
#define NO_ESP32_CRYPT | ||
#warning "Please use NO_ESP32_CRYPT not NO_ESP32WROOM32_CRYPT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend using #error
, not #warning
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks. Over to PR cap.
Description
Adds and/or cleans up wolfcrypt support for ESP-IDF v5.1 for the following SoC chips:
Included is a compile-only fix for esp32c2 and esp32h2. I'll have a new
benchmark.c
update in the near future.The companion #7037 updates the respective benchmark code.
See #6234 for a roadmap of Espressif updates.
Fixes zd# n/s
Testing
How did you test?
Espressif only testing
Checklist