20231208-asn-big-short-ints #7053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* parameterize MAX_LENGTH_SZ using overrideable WOLFSSL_ASN_MAX_LENGTH_SZ, default value 5 (raised from 4). * refactor other Misc_ASN constants to refer to MAX_LENGTH_SZ as appropriate. * tweak BytePrecision() appropriately. * refactor SetShortInt() to use BytePrecision() and include a length assert against MAX_SHORT_SZ to assure no buffer overruns with reduced WOLFSSL_ASN_MAX_LENGTH_SZ.
…ate out AES-XTS functionality that depends on new APIs added in wolfSSL#7031 (b14aba4 and 931ac4e) (AES-XTS is non-FIPS in FIPS <5.3).
|
Retest this please |
SparkiDev
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support ASN ShortInts up to 4 bytes (2^32-1):
MAX_LENGTH_SZusing overrideableWOLFSSL_ASN_MAX_LENGTH_SZ, default value 5 (raised from 4).MAX_LENGTH_SZas appropriate.BytePrecision()appropriately.SetShortInt()to useBytePrecision()and include a length assert againstMAX_SHORT_SZto assure no buffer overruns with reducedWOLFSSL_ASN_MAX_LENGTH_SZ.wolfcrypt/src/evp.candwolfcrypt/test/test.c: in FIPS builds <5.3, gate out AES-XTS functionality that depends on new APIs added in #7031 (b14aba4 and 931ac4e) (AES-XTS is non-FIPS in FIPS <5.3).tested with
wolfssl-multi-test.sh ... super-quick-checkand https://github.com/wolfssl/wolfssl-examples/pkcs7/ hacked to generate and validate a PKCS#7 object larger than 2^24 bytes.