Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdDSA FIPS checks on public key #7433

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

SparkiDev
Copy link
Contributor

Description

Check that the Ed25519 and Ed448 public key is valid even without private key.
Perform pairwise consistency test, only in FIPS, when making a key i Ed25519 and Ed448.

Testing

./configure '--disable-shared' '--enable-curve25519' '--enable-ed25519' '--enable-curve448' '--enable-ed448'

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev requested a review from kaleb-himes April 17, 2024 06:06
@SparkiDev SparkiDev self-assigned this Apr 17, 2024
@SparkiDev SparkiDev force-pushed the eddsa_fips_checks branch 2 times, most recently from 9c2a179 to 22a47c1 Compare April 17, 2024 07:18
Check that the Ed25519 and Ed448 public key is valid even without
private key.
Perform pairwise consistency test, only in FIPS, when making a key i
Ed25519 and Ed448.
@SparkiDev SparkiDev assigned kaleb-himes and unassigned SparkiDev Apr 18, 2024
Copy link
Contributor

@kaleb-himes kaleb-himes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes, CAVP EDDSA keyVer vectors can now pass.

@JacobBarthelmeh JacobBarthelmeh merged commit ef15310 into wolfSSL:master Apr 18, 2024
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants