Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asn template debug fix #7488

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

SparkiDev
Copy link
Contributor

Description

Variable is length instead of len.

Testing

./configure CFLAGS=-DWOLFSSL_DEBUG_ASN_TEMPLATE

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Apr 30, 2024
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Apr 30, 2024
@SparkiDev SparkiDev requested a review from wolfSSL-Bot April 30, 2024 12:45
douzzer
douzzer previously approved these changes May 8, 2024
@SparkiDev SparkiDev dismissed douzzer’s stale review May 8, 2024 22:39

The merge-base changed after approval.

douzzer
douzzer previously approved these changes May 8, 2024
@SparkiDev SparkiDev dismissed douzzer’s stale review May 8, 2024 22:44

The merge-base changed after approval.

@douzzer
Copy link
Contributor

douzzer commented May 8, 2024

apparently there's a bug in github affecting this PR -- the redundant commit (41eaa84) is stuck in the view of changes, but is not an actual candidate for merge, so there's never a match between what's reviewed and what would be merged.

if I have this right, you'll need to rebase and force-push to work around the bug.

@douzzer douzzer assigned SparkiDev and unassigned wolfSSL-Bot May 8, 2024
Variable is length instead of len.
@douzzer douzzer force-pushed the asn_template_debug_fix branch from 413f322 to b62e8c1 Compare May 9, 2024 15:47
@douzzer douzzer merged commit 2335eb6 into wolfSSL:master May 9, 2024
115 checks passed
jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants