LMS, XMSS: move code into wolfCrypt #7500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philljj
requested changes
May 3, 2024
philljj
requested changes
May 3, 2024
SparkiDev
force-pushed
the
lms_xmss_move_wolfcrypt
branch
from
0868c43 to
aca75bf
Compare
|
I've forced a sync of pqcrypto and copied the files over again. |
SparkiDev
force-pushed
the
lms_xmss_move_wolfcrypt
branch
from
aca75bf to
e5bf065
Compare
philljj
requested changes
May 3, 2024
SparkiDev
force-pushed
the
lms_xmss_move_wolfcrypt
branch
from
e5bf065 to
146e094
Compare
Move implementations of LMS and XMSS into wolfCrypt and use by default.
SparkiDev
force-pushed
the
lms_xmss_move_wolfcrypt
branch
from
146e094 to
e47f1d4
Compare
|
retest this please |
|
Retest this please. |
philljj
approved these changes
May 7, 2024
douzzer
approved these changes
May 7, 2024
There was a problem hiding this comment.
tests all good.
[in-tree-lms-xmss-wolfssl-all-gcc-latest] [1 of 6] [e47f1d4190]
autogen.sh e47f1d4190... real 0m16.881s user 0m14.670s sys 0m1.340s
configure... real 0m17.843s user 0m6.623s sys 0m13.144s
build... real 0m41.095s user 2m30.147s sys 0m9.838s
check... real 0m25.821s user 0m18.369s sys 0m11.221s
in-tree-lms-xmss-wolfssl-all-gcc-latest OK
[in-tree-lms-xmss-wolfssl-all-clang-tidy] [2 of 6] [e47f1d4190]
configure... real 0m25.728s user 0m11.404s sys 0m16.173s
build... real 2m36.321s user 18m32.619s sys 0m47.231s
check... real 0m25.632s user 0m21.347s sys 0m11.311s
in-tree-lms-xmss-wolfssl-all-clang-tidy OK
[in-tree-lms-xmss-wolfssl-all-sanitizer] [3 of 6] [e47f1d4190]
configure... real 0m20.011s user 0m8.432s sys 0m13.471s
build... real 2m23.179s user 10m20.806s sys 0m16.832s
check... real 0m31.339s user 0m30.204s sys 0m21.225s
in-tree-lms-xmss-wolfssl-all-sanitizer OK
[in-tree-lms-xmss-wolfssl-all-clang-sanitizer] [4 of 6] [e47f1d4190]
configure... real 0m27.503s user 0m12.613s sys 0m16.744s
build... real 1m39.613s user 7m34.289s sys 0m14.539s
check... real 0m27.992s user 0m25.700s sys 0m18.363s
in-tree-lms-xmss-wolfssl-all-clang-sanitizer OK
[in-tree-lms-xmss-wolfssl-all-cppcheck] [5 of 6] [e47f1d4190]
configure... real 0m17.603s user 0m6.543s sys 0m12.928s
cppcheck... real 1m15.841s user 12m46.903s sys 1m1.772s
in-tree-lms-xmss-wolfssl-all-cppcheck OK
[in-tree-lms-xmss-wolfssl-cross-aarch64-all-armasm-unittest-sanitizer] [6 of 6] [e47f1d4190]
using aarch64-unknown-linux-gnu-gcc 12.3.1
configure... real 0m22.457s user 0m9.569s sys 0m14.874s
build... real 3m24.655s user 12m54.012s sys 0m20.891s
unit.test... real 2m20.388s user 2m16.490s sys 0m0.895s
in-tree-lms-xmss-wolfssl-cross-aarch64-all-armasm-unittest-sanitizer OK
final tally: all 6 selected checks succeeded for e47f1d4190.
also clean: check-file-modes check-source-text check-configure
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
LMS, XMSS: move code into wolfCrypt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move implementations of LMS and XMSS into wolfCrypt and use by default.
Testing
Regression tested LMS and XMSS.
Checklist