Fixes for Segger emNet to handle non-blocking want read/want write #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
dgarske
changed the title
dgarske
commented
May 24, 2024
src/wolfio.c
Outdated
| #elif defined(WOLFSSL_EMNET) | ||
| if (old < 0) { /* SOCKET_ERROR */ | ||
| /* Get the real socket error */ | ||
| getsockopt(sd, SOL_SOCKET, SO_ERROR, &old, (int)sizeof(old)); |
There was a problem hiding this comment.
This actually calls: IP_SOCK_getsockopt and API is int IP_SOCK_getsockopt(int hSock, int Level, int Name, void* pVal, int ValLen). Since the getsockopt is not fully compatible I might change this to use IP_SOCK_getsockopt directly. That API is included via IP/IP.h.
anhu
approved these changes
May 24, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Fixes for Segger emNet to handle non-blocking want read/want write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for EMNET with non-blocking to handle want read/want write. Fix to not include standard POSIX headers like
unistd.hfor EMNET.Fixes ZD 18012
Testing
Customer tested
Checklist