-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DTLS 1.2 Connection ID (CID) #7995
Conversation
4841486
to
d7ab338
Compare
Retest this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the refactor of doing ETM MAC size calculation in a single place, but I found the re-use of keys.PadSz a little misleading. Can you think of a re-name or using an extra variable?
|
5d3b842
to
bf946d2
Compare
bf946d2
to
cf96ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have one more person review this pull request too.
When trying to build using the configure :./configure --enable-dtls --enable-dtlscid --enable-dtls13
tests/api.c:94360:25: error: implicit declaration of function ‘wolfSSL_Rehandshake’; did you mean ‘wolfSSL_BIO_do_handshake’? [-Werror=implicit-function-declaration]
94360 | ExpectIntEQ(wolfSSL_Rehandshake(ssl_c), -1);
| ^~~~~~~~~~~~~~~~~~~
./tests/unit.h:188:24: note: in definition of macro ‘ExpectInt’
Adding secure-renegotiation ./configure --enable-dtls --enable-dtlscid --enable-dtls13 --enable-secure-renegotiation
results in :
911: test_dtls_old_seq_number : passed ( 0.00351)
912: test_dtls12_basic_connection_id :
Testing AES128-SHA256 run #0 ...
ERROR - tests/api.c line 94241 failed with:
expected: wolfSSL_set_cipher_list(ssl_c, params[i]) == 1
result: 0 != 1
failed
Testing AES128-SHA256 run #1 ... failed
retest this please |
@SparkiDev please give this an additional review. |
src/tls.c
Outdated
} | ||
wc_HashFree(&hash, hashType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'hash' may not have been initialised properly.
It' looks fine with the implementation but don't rely on that.
Ran timing test of TLS_hmac and appears fine. |
No description provided.