Fix conversion on various files

[gasbytes]

These ones were linux specific (x86_64 on Void Linux).
Most of them were automated using a shell script that I wrote locally, that uses a vim interactive shell.
Working on the next block of files.

Testing: "gcc (GCC) 13.2.0"

$ ./configure --enable-all CC=gcc 'CFLAGS=-Werror -Wno-pragmas -Wall -Wextra -Wunknown-pragmas --param=ssp-buffer-size=1 -Waddress -Warray-bounds -Wbad-function-cast -Wchar-subscripts -Wcomment -Wfloat-equal -Wformat-security -Wformat=2 -Wmaybe-uninitialized -Wmissing-field-initializers -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wnormalized=id -Woverride-init -Wpointer-arith -Wpointer-sign -Wshadow -Wsign-compare -Wstrict-overflow=1 -Wstrict-prototypes -Wswitch-enum -Wundef -Wunused -Wunused-result -Wunused-variable -Wwrite-strings -fwrapv -Wsign-conversion -fmax-errors=1'
$ make

[douzzer]

rebase+reconciliation needed.

CONFLICT (content): Merge conflict in src/tls.c

looks good otherwise.

[gasbytes]

retest this please

[dgarske]

@gasbytes please share how you produced these conversion warnings. Which complier and what build steps. Thank you

[dgarske]

@gasbytes please squash.

[gasbytes]

@gasbytes please share how you produced these conversion warnings. Which complier and what build steps. Thank you

@dgarske
Of course, version of gcc:

$ gcc --version
$ gcc (GCC) 13.2.0

And this is the configuration, followed just by a make:

$ ./config.status --config
$ --enable-all CC=gcc 'CFLAGS=-Werror -Wno-pragmas -Wall -Wextra -Wunknown-pragmas --param=ssp-buffer-size=1 -Waddress -Warray-bounds -Wbad-function-cast -Wchar-subscripts -Wcomment -Wfloat-equal -Wformat-security -Wformat=2 -Wmaybe-uninitialized -Wmissing-field-initializers -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wnormalized=id -Woverride-init -Wpointer-arith -Wpointer-sign -Wshadow -Wsign-compare -Wstrict-overflow=1 -Wstrict-prototypes -Wswitch-enum -Wundef -Wunused -Wunused-result -Wunused-variable -Wwrite-strings -fwrapv -Wsign-conversion -fmax-errors=1'

[dgarske]

Retest this please:

[make check (macos-latest, --enable-harden-tls)](https://github.com/wolfSSL/wolfssl/pull/8135#logs)

Test complete
wolfSSL error: tcp connect failed: Connection refused

Running simple test
SSL version is TLSv1.2
SSL cipher suite is TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
SSL curve name is SECP256R1
SSL version is TLSv1.2
SSL cipher suite is TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
SSL curve name is SECP256R1
Client message: hello wolfssl!
I hear you fa shizzle!

Running TLS test
FAIL testsuite/testsuite.test (exit status: 1)

./configure --enable-aesgcm=table --enable-all --enable-intelasm --enable-sp-math-all 
FAIL scripts/ocsp-stapling_tls13multi.test (exit status: 1)

[douzzer]

has a slew of conflicts relative to current master:

CONFLICT (content): Merge conflict in configure.ac
CONFLICT (content): Merge conflict in src/ssl.c
CONFLICT (content): Merge conflict in src/tls.c
CONFLICT (content): Merge conflict in tests/quic.c

it's a mystery to me why github thinks "Merging can be performed automatically"...

[gasbytes]

@douzzer

I think this might be because I resolved those conflicts using GitHub's web editor, but I'm not entirely sure why GitHub now says the merge can be performed automatically. As far as I can tell, those files don’t seem to have any breaking changes compared to master, so that might also be a reason.

[douzzer]

retest this please (numerous inexplicable test timeouts)

[douzzer]

@gasbytes -- unfortunately, the history on your branch needs to be completely reset, and the changes need to be reapplied manually relative to master.

The problem is that you did a "Merge branch 'master' into fix-conversion", rather than a git rebase master that would have properly preserved the upstream history.

See the git log for the crazy log entry concatenating a hundred or so commit messages and attributing it to @LinuxJedi for reasons unknown. ("200 files changed, 8520 insertions(+), 2959 deletions(-)") That commit is not in the history of master and shouldn't be in it.

Also this branch now has at least one unwanted and unrelated change in it, to configure.ac, and you're going to need to go through the entire change set to make sure there aren't any others.

One way to fix the mess, tested locally:

git checkout master
git pull upstream master
git checkout fix-conversion
git reset --soft master
git diff master configure.ac | git apply --reverse
git commit -n -a

This will create a single new commit with all your changes except for the configure.ac change, directly atop current master, with a perfectly clean history.

As long as that change to configure.ac was the only mistaken one, that'll do the trick.

[gasbytes]

Retest this please

[douzzer]

The branch has many unintended and unwanted changes, all of them in a single commit at the head.

With the branch checked out,

git show --stat HEAD

shows the problem.

 280 files changed, 7111 insertions(+), 8905 deletions(-)

[dgarske]

Consistently failing on:

   369: test_wolfSSL_ASN1_TIME_print                        :
ERROR - tests/api.c line 52178 failed with:
    expected: memcmp((buf),("Dec 13 22:19:28 2023 GMT"),(sizeof(buf) - 1)) == 0
    result:   5 != 0

 failed (  0.00005)

ERROR - tests/api.c line 100318 failed with:
    expected: Test failed

    result:   ret 0