Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: wolfSSL_BN_CTX_get() note #8359

Closed
wants to merge 1 commit into from

Conversation

SparkiDev
Copy link
Contributor

Description

wolfSSL_BN_CTX_get() returns an object that must be freed.
This is different to BN_CTX_get() in OpenSSL.

Fixes zd#19217

Testing

N/A

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Jan 17, 2025
wolfSSL_BN_CTX_get() returns an object that must be freed.
This is different to BN_CTX_get() in OpenSSL.
@dgarske
Copy link
Contributor

dgarske commented Jan 21, 2025

Retest this please issue with new "generic config"

Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BN_CTX_get gets some usage in the projects I grep'ed. I think its safer to implement a list of allocated BN objects and just free the list with BN_CTX_free. I can put up a PR unless you have a window open to implement it.

@SparkiDev
Copy link
Contributor Author

Open a new PR and fix this when you have time. Make it a compile time thing to not have it.
This PR needs to go in now for current customers.
It is not a small amount of work to create a BN_CTX with a list of BIGNUMs as it is just a dummy right now.

@SparkiDev SparkiDev assigned julek-wolfssl and unassigned SparkiDev Jan 28, 2025
@julek-wolfssl
Copy link
Member

Implemented BN_CTX_get at #8388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants