Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake lean_tls build #8460

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Fix cmake lean_tls build #8460

merged 2 commits into from
Feb 17, 2025

Conversation

embhorn
Copy link
Member

@embhorn embhorn commented Feb 17, 2025

Description

Cmake build with -DWOLFSSL_LEAN_TLS=ON should also add NO_WOLFSSL_MEMORY

Fixes #8456

Testing

wolfssl/build$ cmake .. -DWOLFSSL_LEAN_TLS=ON
wolfssl/build$ cmake --build .

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@embhorn
Copy link
Member Author

embhorn commented Feb 17, 2025

Retest this please

[PRB-generic-config-parser #7322](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/7322/) completed with status FAILURE (propagate: false to ignore)
org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 9b3991b6-fa22-4198-8d6d-6ce8f6ce8e46
Setting overall build result to FAILURE

@embhorn embhorn requested a review from wolfSSL-Bot February 17, 2025 15:34
@embhorn embhorn assigned wolfSSL-Bot and unassigned embhorn Feb 17, 2025
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to add this build to the new GitHub CI?
https://github.com/wolfSSL/wolfssl/blob/master/.github/workflows/cmake.yml

@dgarske dgarske removed the request for review from wolfSSL-Bot February 17, 2025 19:23
@embhorn
Copy link
Member Author

embhorn commented Feb 17, 2025

retest this please

Also:   org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 1eef8169-0c37-4b22-8ba8-92a587aa56eb
Also:   	Also:   org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 2a0c3a3b-5912-42f6-afe3-d61042cfcff0
org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-v35zzn; wolf-linux-cloud-node-v35zzn was marked offline: Connection was broken

@dgarske dgarske merged commit a2c8168 into wolfSSL:master Feb 17, 2025
178 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cmake - WOLFSSL_LEAN_TLS broken
3 participants