Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox/133.0 package update #35153

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Nov 25, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Nov 25, 2024
Copy link
Contributor Author

octo-sts bot commented Nov 25, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I'll provide a detailed analysis and solution:

• Detected Error:

abort: unknown revision 'FIREFOX_133_0_RELEASE'

• Error Category: Version/Configuration

• Failure Point:
The hg clone command with specified tag FIREFOX_133_0_RELEASE

• Root Cause Analysis:
The release tag format being used doesn't match Mozilla's actual tag naming convention for Firefox releases. Mozilla uses a different format for their Mercurial tags.

• Suggested Fix:
Modify the release tag format in the pipeline section. Replace:

RELEASE_TAG=FIREFOX_${{vars.mangled-package-version}}_RELEASE

with:

RELEASE_TAG=FIREFOX_${package.version}_RELEASE
# Or more specifically:
RELEASE_TAG=FIREFOX_133_0_RELEASE_b1

• Explanation:
Mozilla's Firefox release tags follow a specific format that includes additional information beyond just the version number. The correct tag can be found by checking Mozilla's release repository tags. The build fails because it's trying to find a tag that doesn't exist in Mozilla's repository.

• Additional Notes:

  1. Mozilla sometimes uses additional suffixes like '_b1' or '_rc1' in their tags
  2. You can verify correct tags by checking:
  3. Consider adding a var-transform to handle the tag format conversion

• References:

@debasishbsws debasishbsws self-assigned this Nov 26, 2024
Copy link
Contributor

Package firefox: Click to expand/collapse

Package firefox:

.PKGINFO metadata:

  (
  	"""
  	# Generated by melange
  	pkgname = firefox
- 	pkgver = 132.0.2-r0
+ 	pkgver = 133.0-r0
  	arch = x86_64
- 	size = 264111914
+ 	size = 265796716
  	origin = firefox
  	pkgdesc = Firefox web browser
  	url = 
- 	commit = 0a7c45840a3b99483e8559a54f5932d27fa5afc5
- 	builddate = 1732133258
+ 	commit = f2236f658a174075d1a0189ab4dfc8fd7b787a1d
+ 	builddate = 1732635918
  	license = GPL-3.0-only AND LGPL-2.1-only AND LGPL-3.0-only AND MPL-2.0
  	depend = mesa
  	... // 49 identical lines
  	# vendored = so:libssl3.so=0
  	# vendored = so:libxul.so=0
- 	datahash = 1aa93d92b0b5edfdab94756bafc13e7c0528769e37e0162fe60f5b1997dea559
+ 	datahash = f34872be9cc64086077ab69f950f58f286854ca9c86dc66bf920cf4ac775f60b
  	"""
  )

Modified: /usr/lib/firefox/application.ini
Modified: /usr/lib/firefox/browser/features/[email protected]
Modified: /usr/lib/firefox/browser/features/[email protected]
Modified: /usr/lib/firefox/browser/omni.ja
Modified: /usr/lib/firefox/crashreporter
Modified: /usr/lib/firefox/firefox
Modified: /usr/lib/firefox/firefox-bin
Modified: /usr/lib/firefox/glxtest
Modified: /usr/lib/firefox/gmp-clearkey/0.1/libclearkey.so
Modified: /usr/lib/firefox/libfreeblpriv3.so
Modified: /usr/lib/firefox/libgkcodecs.so
Modified: /usr/lib/firefox/libipcclientcerts.so
Modified: /usr/lib/firefox/liblgpllibs.so
Modified: /usr/lib/firefox/libmozavcodec.so
Modified: /usr/lib/firefox/libmozavutil.so
Modified: /usr/lib/firefox/libmozgtk.so
Modified: /usr/lib/firefox/libmozsandbox.so
Modified: /usr/lib/firefox/libmozsqlite3.so
Modified: /usr/lib/firefox/libmozwayland.so
Modified: /usr/lib/firefox/libnspr4.so
Modified: /usr/lib/firefox/libnss3.so
Modified: /usr/lib/firefox/libnssckbi.so
Modified: /usr/lib/firefox/libnssutil3.so
Modified: /usr/lib/firefox/libplc4.so
Modified: /usr/lib/firefox/libplds4.so
Modified: /usr/lib/firefox/libsmime3.so
Modified: /usr/lib/firefox/libsoftokn3.so
Modified: /usr/lib/firefox/libssl3.so
Modified: /usr/lib/firefox/libxul.so
Modified: /usr/lib/firefox/omni.ja
Modified: /usr/lib/firefox/pingsender
Modified: /usr/lib/firefox/platform.ini
Modified: /usr/lib/firefox/precomplete
Modified: /usr/lib/firefox/updater
Modified: /usr/lib/firefox/vaapitest
Deleted: /usr/lib/firefox/minidump-analyzer

@octo-sts octo-sts bot added bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. and removed bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. labels Nov 26, 2024
@debasishbsws debasishbsws merged commit 49b9c0b into main Nov 26, 2024
18 of 19 checks passed
@debasishbsws debasishbsws deleted the wolfictl-12311a25-ba10-4312-90c2-884ee6c3ee85 branch November 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants