Migrate teleport package to use go/build #35267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octo-sts
bot
added
the
bincapz/pass
mamccorm
force-pushed
the
teleport-update
branch
from
73ffcf1 to
0c9eae3
Compare
Signed-off-by: Mark McCormick <[email protected]> Fix teleport build after refactor to go/build Signed-off-by: Mark McCormick <[email protected]> linter fixes Signed-off-by: Mark McCormick <[email protected]> bump to latest version and digest Signed-off-by: Mark McCormick <[email protected]> Expand functional test coverage Signed-off-by: Mark McCormick <[email protected]> removing duplicate test Signed-off-by: Mark McCormick <[email protected]> fix test Signed-off-by: Mark McCormick <[email protected]>
mamccorm
force-pushed
the
teleport-update
branch
from
0c9eae3 to
d546a2e
Compare
Signed-off-by: Mark McCormick <[email protected]>
developer-guy
previously approved these changes
Nov 26, 2024
Signed-off-by: Mark McCormick <[email protected]>
xnox
reviewed
Nov 27, 2024
xnox
reviewed
Nov 27, 2024
xnox
reviewed
Nov 27, 2024
xnox
reviewed
Nov 27, 2024
Co-authored-by: Dimitri John Ledkov <[email protected]> Signed-off-by: Mark McCormick <[email protected]>
Signed-off-by: Mark McCormick <[email protected]>
|
Ready for another review @xnox, @philroche. All PR feedback should be addressed |
philroche
approved these changes
Dec 1, 2024
xnox
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The teleport build was leveraging the upstream projects make build, to produce the binaries. This meant we were missing binary optimisations by not leveraging our own go/build pipeline.
The changes in this PR flip the package over to using go/build for the various components.