Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: test: ldd-check: Add "packages" input parameter #38563

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

dannf
Copy link
Contributor

@dannf dannf commented Dec 31, 2024

gcc currently fails to test on ARM because some of the filenames we provide to test/ldd-check are architecture-specific.

This should unblock #35302

Static file lists easily grow out of date, and package
contents may vary by architecture. Allow users to just
provide a list of package names. ldd-check will test
all dynamic ELF binaries found within those packages.

Instead of NIH'ing a "is this a dynamic ELF binary" check,
I just use `ldd` to determine this. It does mean that
we end up running `ldd` twice on every ELF binary from
the package list, but that seems fine for a test case.

Signed-off-by: dann frazier <[email protected]>
Some of the files we are providing to ldd-check are
x86-specific. Use the "packages" option to test/ldd-check
to dynamically determine the package contents.

Signed-off-by: dann frazier <[email protected]>
@dannf dannf added approved-to-run A repo member has approved this external contribution eng:os labels Dec 31, 2024
@dannf dannf requested review from smoser and murraybd December 31, 2024 18:21
@dannf dannf merged commit 9cbaa8b into wolfi-dev:main Jan 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-run A repo member has approved this external contribution eng:os
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants