-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kotlin encoder #55
base: master
Are you sure you want to change the base?
Conversation
@hangduykhiem Please review this 🙏 |
Sorry this got lost in my inbox. Will review ASAP. |
I tried this with the Mona Lisa and the result is not as expected 🤔 |
@connyduck In demo app the ratio is |
changing the ratio only stretches the gradient |
Yup, I tried with both config and the result is similar to Connyduck's finding. For comparison, this is the result of web encoder And the string is Edit: Here's one more comparison so that we can figure out where the bug is. The first one on blurha.sh decoded to |
Actually now that I think of it, @DagAgren's vision is that encode and decode are separate files that can be copy directly to the user directory.
Can you make it so that each of them are self contained? Else I think we might need to move the whole thing to bintray or somewhere else to make it easier for others. |
I'm thinking of something like comparing the output of the first image with |
All being said, thank you for the PR, @hearsilent. I meant to do this a while ago, but... 😅 |
@connyduck @hangduykhiem I've fixed encode with wrong result. It cause by |
Can you please merge this? I would like to use it, but I'll use https://github.com/hsch/blurhash-java for now. |
#41