Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter to update Level 3 data #3286

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

peterfabian
Copy link
Contributor

@peterfabian peterfabian commented Jul 18, 2024

Allow filtering level 3 data

This PR adds support to allow the use of WooCommerce Gift cards to pay for order partially with full support of Level 3 data, with the rest being paid by another payment method provided by Stripe. This previously failed due to Level 3 data mismatch.

Description

Together with https://github.com/woocommerce/woocommerce-gift-cards/pull/822 adds support for gift cards to be used as discounts with full support for Level 3 data while using Stripe to pay for the remaining amount (not covered by the gift card).

More background discussion available at p1718202231605999-slack-C3NCP7ZJ6

A similar chance is being done also in WooPayments: Automattic/woocommerce-payments#9053

Changes proposed in this Pull Request:

A minimal change: adds filter wc_stripe_payment_request_level3_data to allow updating Level 3 data for Stripe so that the data matches and order can be processed.

Haven't added tests since we'd be only testing WordPress filtering.

Testing instructions

Please check https://github.com/woocommerce/woocommerce-gift-cards/pull/822.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@peterfabian peterfabian marked this pull request as ready for review July 18, 2024 09:25
Copy link
Contributor

@james-allan james-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks for the PR @peterfabian!

@PanosSynetos PanosSynetos merged commit 06ff0c6 into develop Jul 22, 2024
32 of 33 checks passed
@PanosSynetos PanosSynetos deleted the add/gc-as-discount branch July 22, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants