-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix order attribution data with ECE and Blocks API #3722
Merged
Merged
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/woocommerce/woocommerce-gateway-stripe into tweak/using-blocks-api-to-process-ece-orders
Co-authored-by: Mayisha <[email protected]>
wjrosa
requested review from
a team and
diegocurbelo
and removed request for
a team
January 14, 2025 15:35
…gateway-stripe into fix/order-attribution-data-with-blocks-api
diegocurbelo
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @wjrosa!
The code looks good, and it tests well 🚢
Base automatically changed from
tweak/using-blocks-api-to-process-ece-orders
to
develop
January 20, 2025 13:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1573
Base PR #3691
Changes proposed in this Pull Request:
With the introduction of #3691, order attribution data was lost (it was added in #3629). This PR fixes that by applying a new filter on the frontend.
This is heavily inspired by the implementation done in WooPayments here. Except that we are not calling or organising this part of the code as "tokenized express checkout".
Testing instructions
fix/order-attribution-data-with-blocks-api
)true
as the returning value ofuse_blocks_api
?utm_source=Facebook
changelog.txt
andreadme.txt
(or does not apply)Post merge