-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] [Design System] Apply straightforward color updates #15068
Changes from 19 commits
0d82d75
a445269
0d0e84b
a4049c2
6f84b09
690d36b
da37b47
e6ca856
ed832c5
21fa12a
f9b515e
25a77a5
a405984
c1d5de4
26d1fc8
ac009e8
6a67d6d
5aed9e9
b2529ec
4010bf7
41ac7aa
5dd6465
ac3c0e0
b727822
8d038e7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,11 +94,11 @@ struct TotalsView: View { | |
private var backgroundColor: Color { | ||
switch posModel.paymentState { | ||
case .card(.cardPaymentSuccessful), .cash(.paymentSuccess): | ||
.posSecondaryBackground | ||
.posSurfaceContainerLowest | ||
case .card(.processingPayment): | ||
colorScheme == .light ? Color(.wooCommercePurple(.shade70)) : Color(.wooCommercePurple(.shade10)) | ||
.posPrimary | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is the color used in the design system: 1qcjzXitBHU7xPnpCOWnNM-fi-256_15446 The previous primary button (now called "filled" style in the design system) color is also the same in both light and dark mode now. |
||
case .cash(.collectingCash): | ||
colorScheme == .light ? .clear : Color.posSecondaryBackground | ||
.posSurface | ||
default: | ||
.clear | ||
} | ||
|
@@ -357,7 +357,7 @@ private extension TotalsView { | |
static let subtotalAmountFont: POSFontStyle = .posBodyRegular | ||
static let totalTitleFont: POSFontStyle = .posTitleRegular | ||
static let totalAmountFont: POSFontStyle = .posTitleEmphasized | ||
static let separatorColor: Color = Color(.systemGray3) | ||
static let separatorColor: Color = Color.posOutlineVariant | ||
|
||
static let shimmeringCornerRadius: CGFloat = 4 | ||
static let shimmeringWidth: CGFloat = 334 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 👀 was this a
SwiftUI
import maybe?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was from an auto-fix action in Xcode, but I agree
SwiftUI
import is more standard and avoid confusion in the future why it'sSwiftUICore
here. Updated in 5dd6465