WaitingTimeTracker improvements #15082
Open
+63
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a side-quest from #15047 to improve WaitingTimeTracker's readability. In that PR we reused the existing
WaitingTimeTracker
to capture POS events in milliseconds without realizing the actual elapsed time was being captured in seconds. With these changes we extend the class to allow both, and be more explicit about it.Changes:
...InMillis
property in the interface to avoid using it incorrectly by mistake, by being explicit about the time unit.Testing information
WooAnalyticsEvent.WaitingTime.Scenario
are still tracked in seconds with the keywaiting_time
. For example these two run as soon as we load the app:milliseconds_time_elapsed_in_splash_screen
:Tested in simulator iPad Air 11 iOS 17.5
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: