Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix repo links #145

Merged
merged 1 commit into from
Nov 10, 2024
Merged

fix(docs): fix repo links #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions docs/audits.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ typically via GitHub Actions artifact creation or action logs.

### Why

The default checkout action is [`actions/checkout`].
The default checkout action is @actions/checkout.

By default, using `actions/checkout` causes a credential to be persisted
By default, using @actions/checkout causes a credential to be persisted
in the checked-out repo's `.git/config`, so that subsequent `git` operations
can be authenticated.

Subsequent steps may accidentally publicly persist `.git/config`, e.g. by
including it in a publicly accessible artifact via [`actions/upload-artifact`].
including it in a publicly accessible artifact via @actions/upload-artifact.

However, even without this, persisting the credential in the `.git/config`
is non-ideal and should be disabled with `persist-credentials: false` unless
Expand All @@ -42,10 +42,6 @@ the job actually needs the persisted credential.

* <https://unit42.paloaltonetworks.com/github-repo-artifacts-leak-tokens/>

[`actions/checkout`]: https://github.com/actions/checkout

[`actions/upload-artifact`]: https://github.com/actions/upload-artifact

## `dangerous-triggers`

| Type | Examples | Introduced in | Works offline | Enabled by default |
Expand Down