Skip to content

Commit

Permalink
fix: fixes after audit
Browse files Browse the repository at this point in the history
  • Loading branch information
MishaShWoof committed Jan 30, 2025
1 parent 4351754 commit 56e20cc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ let newCometExtAddressWETH: string;
let newCometExtAddressUSDCE: string;

const USDCE_COMET = '0xA5EDBDD9646f8dFF606d7448e414884C7d905dCA';
const USDCE_EXT = '0x1B2E88cC7365d90e7E81392432482925BD8437E9';
const USDT_COMET = '0xd98Be00b5D27fc98112BdE293e487f8D4cA57d07';
const USDT_EXT = '0x698A949f3b4f7a5DdE236106F25Fa0eAcA0FcEF1';
const WETH_COMET = '0x6f7D514bbD4aFf3BcD1140B7344b32f063dEe486';
Expand Down Expand Up @@ -108,16 +107,8 @@ export default migration('1735299626_update_comet_to_support_more_collaterals',
true
);

const extensionDelegateUSDCE = new Contract(
USDCE_EXT,
[
'function name() external view returns (string)',
'function symbol() external view returns (string)',
],
await deploymentManager.getSigner()
);
const nameUSDCE = await extensionDelegateUSDCE.name();
const symbolUSDCE = await extensionDelegateUSDCE.symbol();
const nameUSDCE = 'Compound USDCe';
const symbolUSDCE = 'cUSDCev3';

const _newCometExtUSDCE = await deploymentManager.deploy(
'CometExtAssetList',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export default migration('1735299799_update_comet_to_support_more_collaterals',
},
];

const description = '# Update USDC, USDT and WETH Comets on Optimism to support more collaterals\n\n## Proposal summary\n\nCompound Growth Program [AlphaGrowth] proposes to update 4 Comets to a new version, which supports up to 24 collaterals. This proposal takes the governance steps recommended and necessary to update Compound III USDT, USDC and WETH markets on Optimism. Simulations have confirmed the market’s readiness, as much as possible, using the [Comet scenario suite](https://github.com/compound-finance/comet/tree/main/scenario).\n\nDetailed information can be found on the corresponding [proposal pull request](https://github.com/compound-finance/comet/pull/904) and [forum discussion](https://www.comp.xyz/t/increase-amount-of-collaterals-in-comet/5465).\n\n\n## Proposal Actions\n\nThe first action sets the factory to the newly deployed factory, extension delegate to the newly deployed contract and deploys and upgrades Comet to a new version for all 3 comets: cUSDTv3, cUSDCv3 and cWETHv3.';
const description = '# Update USDC, USDT and WETH Comets on Optimism to support more collaterals\n\n## Proposal summary\n\nCompound Growth Program [AlphaGrowth] proposes to update 3 Comets to a new version, which supports up to 24 collaterals. This proposal takes the governance steps recommended and necessary to update Compound III USDT, USDC and WETH markets on Optimism. Simulations have confirmed the market’s readiness, as much as possible, using the [Comet scenario suite](https://github.com/compound-finance/comet/tree/main/scenario).\n\nDetailed information can be found on the corresponding [proposal pull request](https://github.com/compound-finance/comet/pull/904) and [forum discussion](https://www.comp.xyz/t/increase-amount-of-collaterals-in-comet/5465).\n\n\n## Proposal Actions\n\nThe first action sets the factory to the newly deployed factory, extension delegate to the newly deployed contract and deploys and upgrades Comet to a new version for all 3 comets: cUSDTv3, cUSDCv3 and cWETHv3.';
const txn = await deploymentManager.retry(async () =>
trace(
await governor.propose(...(await proposal(mainnetActions, description)))
Expand Down
6 changes: 3 additions & 3 deletions scenario/constraints/ProposalConstraint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ export class ProposalConstraint<T extends CometContext> implements StaticConstra
);
}

// temporary hack to skip proposal 385
if (proposal.id.eq(385)) {
console.log('Skipping proposal 385');
// temporary hack to skip proposal 393
if (proposal.id.eq(393)) {
console.log('Skipping proposal 393');
continue;
}

Expand Down

0 comments on commit 56e20cc

Please sign in to comment.