New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Сomet with extended asset list #53

Open

MishaShWoof wants to merge 46 commits into main from woof-software/collateral-extension

Collaborator

MishaShWoof commented Aug 9, 2024

No description provided.


          feat: create comet with extended asset list

bba7d99

github-advanced-security bot found potential problems

View reviewed changes

contracts/AssetList.sol Fixed Show fixed Hide fixed

contracts/AssetList.sol Fixed Show fixed Hide fixed

contracts/AssetList.sol Fixed Show fixed Hide fixed

contracts/AssetList.sol Fixed Show fixed Hide fixed

contracts/AssetList.sol Fixed Show fixed Hide fixed

contracts/CometExtendedAssetList.sol Fixed Show fixed Hide fixed

contracts/CometExtendedAssetList.sol Fixed Show fixed Hide fixed

contracts/CometExtendedAssetList.sol Fixed Show fixed Hide fixed

contracts/CometExtendedAssetList.sol Fixed Show fixed Hide fixed

contracts/CometExtendedAssetList.sol Fixed Show fixed Hide fixed


          feat: move new cometExt to its own contract

fc16ae0

github-advanced-security bot found potential problems

View reviewed changes

contracts/CometExtAssetList.sol Dismissed Show dismissed Hide dismissed

contracts/CometExtAssetList.sol Dismissed Show dismissed Hide dismissed

contracts/CometExtAssetList.sol Dismissed Show dismissed Hide dismissed

MishaShWoof added 2 commits

August 12, 2024 12:20


          fix: clean up

6b62ee6


          fix: gas optimization

d06a3f6

github-advanced-security bot found potential problems

View reviewed changes

contracts/AssetList.sol Outdated

Comment on lines 30 to 38

+                  constructor(CometConfiguration.AssetConfig[] memory assetConfigs) {
+                      uint8 _numAssets = uint8(assetConfigs.length);
+                      numAssets = _numAssets;
+                      for (uint i = 0; i < _numAssets; i++) {
+                          (uint256 asset_a, uint256 asset_b) = getPackedAssetInternal(assetConfigs, i);
+                          assets_a.push(asset_a);
+                          assets_b.push(asset_b);
+                      }
+                  }

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument assetConfigs.

contracts/AssetList.sol Outdated

Comment on lines 30 to 38

+                  constructor(CometConfiguration.AssetConfig[] memory assetConfigs) {
+                      uint8 _numAssets = uint8(assetConfigs.length);
+                      numAssets = _numAssets;
+                      for (uint i = 0; i < _numAssets; i++) {
+                          (uint256 asset_a, uint256 asset_b) = getPackedAssetInternal(assetConfigs, i);
+                          assets_a.push(asset_a);
+                          assets_b.push(asset_b);
+                      }
+                  }

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.non-payable-constructor Note

Consider making costructor payable to save gas.

contracts/AssetList.sol Fixed Show fixed Hide fixed

contracts/AssetList.sol Fixed Show fixed Hide fixed

MishaShWoof added 4 commits

August 12, 2024 13:04


          fix: more gas optimization

d2873ad


          fix: linter fix

5e867a0


          fix: natspec

8ab1786


          fix: more natspec

171eb7a

github-advanced-security bot found potential problems

View reviewed changes

contracts/AssetList.sol Fixed Show fixed Hide fixed

MishaShWoof and others added 14 commits

August 23, 2024 19:06


          Update index.ts

53f1513


          fix: remove unused iterface

8df38e6


          feat: add prepare and enact for simulation

70e8a73


          fix: fix to workflow

4c0a8f4


          Update enact-migration.yaml

c29f4b9


          fix: reverse

cf08c19


          feat: add prepare and enact workflow

71fee7b


          feat: update enact migration script

57d04f7


          feat: update enact migration script

f0c33a1


          feat: update enact migration script

df2d152


          feat: update enact migration script

92937aa


          fix: remove verification from simulatative migration

b72092c


          Merge branch 'main' of github.com:woof-software/comet into woof-softw…

ea15450

…are/collateral-extension


          feat: fixes after audit

dfe98c9

github-advanced-security bot found potential problems

View reviewed changes

contracts/CometExtendedAssetList.sol Fixed Show fixed Hide fixed

MishaShWoof added 3 commits

September 19, 2024 19:43


          fix: working tests

4f2ba04


          fix: no network issue resolved

e641f95


          Merge branch 'main' into woof-software/collateral-extension

986efa2

MishaShWoof and others added 19 commits

December 23, 2024 14:35


          fix: audit fixes

5c75787

fix

4e41a94


          Merge branch 'woof-software/fix-to-no-network' of github.com:woof-sof…

547e934

…tware/comet into woof-software/collateral-extension


          feat: working scenarios


          feat: migrations and working scenarios

4ba3b92

fix

c792011


          fix: secret fix for scroll

9d67b33


          fix: increase arbitrary number

978dec0


          fix: scroll scan fix

b6fb6a2


          feat: migrations and descriptions

6a7f18a

fix

d7d9c2c


          update descriptions

262fb3b

fix

1b4307b


          fix: review fix


          fix: naming fix

40e0370


          fix: optimizer

fb9f9b5


          fix: second optimizer fix

f4860cf


          fix: optimization

94131ad


          Merge pull request #100 from woof-software/woof-software/collateral-e…

b6ff78e

…xtension-audit-fix

Audit fixes to collateral extension

github-advanced-security bot found potential problems

View reviewed changes

contracts/CometWithExtendedAssetList.sol

+                      uint startGas = gasleft();
+                      accrueInternal();
+                      for (uint i = 0; i < accounts.length; ) {

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.array-length-outside-loop Note

Caching the array length outside a loop saves reading it on each iteration, as long as the array's length is not changed during the loop.

contracts/CometWithExtendedAssetList.sol

+                      accrueInternal();
+                      for (uint i = 0; i < accounts.length; ) {
+                          absorbInternal(absorber, accounts[i]);
+                          unchecked { i++; }

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

contracts/CometWithExtendedAssetList.sol

+                      // Using gas price instead of base fee would more accurately reflect spend,
+                      //  but is also subject to abuse if refunds were to be given automatically.
+                      LiquidatorPoints memory points = liquidatorPoints[absorber];
+                      points.numAbsorbs++;

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

contracts/CometWithExtendedAssetList.sol

+                      uint8 _reserved = accountUser._reserved;
+                      uint256 basePrice = getPrice(baseTokenPriceFeed);
+                      uint256 deltaValue = 0;

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.init-variables-with-default-value Note

Uninitialized variables are assigned with the types default value.
Explicitly initializing a variable with its default value costs unnecessary gas.

contracts/CometWithExtendedAssetList.sol

+                              emit AbsorbCollateral(absorber, account, asset, seizeAmount, value);
+                          }
+                          unchecked { i++; }

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

contracts/CometWithExtendedAssetList.sol

+                      if (isBuyPaused()) revert Paused();
+                      int reserves = getReserves();
+                      if (reserves >= 0 && uint(reserves) >= targetReserves) revert NotForSale();

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.


          fix: merge fix

5fe26a2

dmitriy-woof-software reviewed

View reviewed changes

deployments/mainnet/usdc/migrations/1735299739_update_comet_to_support_more_collaterals.ts

+                  const { timelock } = await deploymentManager.getContracts();
+                  // impersonate the timelock
+                  await deploymentManager.hre.network.provider.request({

Member

dmitriy-woof-software Jan 17, 2025

remove


          fix: extension delegate fix and linter fix

d3522dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet