forked from woowacourse/java-blackjack
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dazzle 블랙잭 2단계 #14
Open
woo-chang
wants to merge
38
commits into
woowacourse-code-review-study:woo-chang
Choose a base branch
from
woo-chang:step2
base: woo-chang
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dazzle 블랙잭 2단계 #14
woo-chang
wants to merge
38
commits into
woowacourse-code-review-study:woo-chang
from
woo-chang:step2
Commits on Mar 6, 2023
-
[1단계 - 블랙잭 게임 실행] 다즐(최우창) 미션 제출합니다. (woowacourse#443)
* docs: 요구사항 명세 작성 * feat: 이름의 길이 검증 기능 구현 * feat: 금지된 이름 검증 기능 구현 * docs: 기능 구현 목록 수정 Co-authored-by: woo-chang <[email protected]> * feat: 이름 도메인 생성 Co-authored-by: woo-chang <[email protected]> * feat: 문양 도메인 생성 Co-authored-by: woo-chang <[email protected]> * feat: 숫자 도메인 생성 Co-authored-by: woo-chang <[email protected]> * feat: 문양 이름 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 숫자 이름 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 점수 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 점수 계산 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 에이스인지 확인하는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 점수 합계 계산 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 점수 최댓값 초과 여부 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 이름 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 블랙잭 여부 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * fix: 메서드명 수정 및 잘못된 로직 수정 Co-authored-by: woo-chang <[email protected]> * feat: 카드 추가 여부 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 카드 추가 기능 구현 Co-authored-by: woo-chang <[email protected]> * chore: 테스트 어노테이션 추가 Co-authored-by: woo-chang <[email protected]> * feat: 카드를 받는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 점수 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 개수 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 카드 추가 여부 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 점수 확인 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 카드를 받는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 딜러 도메인 생성 Co-authored-by: woo-chang <[email protected]> * feat: 참가자 도메인 생성 Co-authored-by: woo-chang <[email protected]> * feat: 딜러와 플레이어가 참가자 상속 Co-authored-by: woo-chang <[email protected]> * feat: 플레이어의 이름 중복 검증 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 참가자 인원 검증 기능 구현 Co-authored-by: woo-chang <[email protected]> * refactor: 외부 참조 끊도록 수정 Co-authored-by: woo-chang <[email protected]> * feat: 카드를 뽑는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 덱 상태 검증 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 덱 섞는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 덱 팩토리 도메인 생성 Co-authored-by: woo-chang <[email protected]> * chore: 패키지 분리 및 import 최적화 Co-authored-by: woo-chang <[email protected]> * feat: 문자열 파싱 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 문자열 앞뒤 공백 제거 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 플레이어 이름 목록 입력 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 카드 받을 여부 입력 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 참가자들의 카드 현황 출력 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 딜러 카드 추가 여부 출력 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 최종 결과 출력 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 최종 승패 출력 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 빈 생성자로 생성될 수 있는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: Cards 도메인에 대한 DTO 생성 Co-authored-by: woo-chang <[email protected]> * feat: 딜러 상태에 대한 DTO 생성 Co-authored-by: woo-chang <[email protected]> * feat: 참가자에 대한 DTO 생성 Co-authored-by: woo-chang <[email protected]> * feat: 플레이어 결과에 대한 DTO 생성 Co-authored-by: woo-chang <[email protected]> * feat: 결과에 대한 열거형 도메인 생성 Co-authored-by: woo-chang <[email protected]> * feat: 점수에 대한 도메인 생성 Co-authored-by: woo-chang <[email protected]> * feat: 참가자들이 카드를 뽑는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 참가자들 중 딜러와 플레이어를 찾는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 이름으로만 생성될 수 있는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 덱에서 카드를 뽑아 참가자들에게 나눠주는 기능 구현 Co-authored-by: woo-chang <[email protected]> * feat: 블랙잭 게임 실행 기능 구현 Co-authored-by: woo-chang <[email protected]> * fix: 게임 결과 로직 수정 Co-authored-by: woo-chang <[email protected]> * refactor: TRUMP는 덱이 알도록 수정 * refactor: 입력 기능 가독성 위해 메서드명 수정 * refactor: 축약하지 않은 변수명으로 수정 * refactor: 딜러가 카드를 추가로 뽑을 수 있는 점수는 딜러가 알도록 수정 * refactor: ACE -> Ace 일관성있는 표현으로 수정 * refactor: 테스트 목적을 명확히하도록 수정 * refactor: 계층 구조 테스트로 의미를 명확하게 전달하도록 수정 * refactor: 자바 컨벤션에 따라 메서드명 수정 * refactor: 카드 뽑을 때 검증하도록 수정 * refactor: NPE 방지 및 변수, 메서드명 수정 * refactor: 참가자에게 딜러 여부에 대한 메시지를 던지도록 수정 * refactor: 거짓 성공을 막기위해 검증부에는 하드코딩 하도록 수정 * refactor: TRUMP 생성 시 flatMap 사용 및 덱 생성 시 섞도록 수정 * refactor: 플레이어 이름을 명시하도록 Name -> PlayerName 수정 * refactor: 참여자 목록 생성 책임을 생성자로 수정 * refactor: Deck 생성 책임은 Deck이 가지도록 수정 * refactor: 블랙잭 게임 컨트롤러 수정 * refactor: 딜러 승패 여부 확인 로직 수정 * refactor: 카드 목록에서 사용되지 않는 메서드 제거 * refactor: 딜러가 결과 확인하는 로직 수정 * test: 테스트하지 못했던 코드에 대한 테스트 코드 작성 * feat: 제네릭 미션 구현 --------- Co-authored-by: kokodak <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 095f92f - Browse repository at this point
Copy the full SHA 095f92fView commit details
Commits on Mar 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 72d2d7f - Browse repository at this point
Copy the full SHA 72d2d7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30252f1 - Browse repository at this point
Copy the full SHA 30252f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9fc77d - Browse repository at this point
Copy the full SHA b9fc77dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 705379f - Browse repository at this point
Copy the full SHA 705379fView commit details
Commits on Mar 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 004c830 - Browse repository at this point
Copy the full SHA 004c830View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcf4974 - Browse repository at this point
Copy the full SHA fcf4974View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1da866c - Browse repository at this point
Copy the full SHA 1da866cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4712a7 - Browse repository at this point
Copy the full SHA c4712a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3e8f60 - Browse repository at this point
Copy the full SHA e3e8f60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d7034c - Browse repository at this point
Copy the full SHA 0d7034cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e2ae57 - Browse repository at this point
Copy the full SHA 9e2ae57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7681194 - Browse repository at this point
Copy the full SHA 7681194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38dcf8c - Browse repository at this point
Copy the full SHA 38dcf8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd50b64 - Browse repository at this point
Copy the full SHA fd50b64View commit details -
Configuration menu - View commit details
-
Copy full SHA for be602fd - Browse repository at this point
Copy the full SHA be602fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b0c9d4 - Browse repository at this point
Copy the full SHA 3b0c9d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fd9dea - Browse repository at this point
Copy the full SHA 4fd9deaView commit details
Commits on Mar 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2ed62c4 - Browse repository at this point
Copy the full SHA 2ed62c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b51f1b - Browse repository at this point
Copy the full SHA 1b51f1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for de2820a - Browse repository at this point
Copy the full SHA de2820aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69bff94 - Browse repository at this point
Copy the full SHA 69bff94View commit details
Commits on Mar 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0fe6fd4 - Browse repository at this point
Copy the full SHA 0fe6fd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a5d76b - Browse repository at this point
Copy the full SHA 9a5d76bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2e97f6 - Browse repository at this point
Copy the full SHA a2e97f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bafa2c4 - Browse repository at this point
Copy the full SHA bafa2c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff230c0 - Browse repository at this point
Copy the full SHA ff230c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for db5dc6e - Browse repository at this point
Copy the full SHA db5dc6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 388fd96 - Browse repository at this point
Copy the full SHA 388fd96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aea768 - Browse repository at this point
Copy the full SHA 5aea768View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d15375 - Browse repository at this point
Copy the full SHA 3d15375View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe0e83 - Browse repository at this point
Copy the full SHA cbe0e83View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7d6079 - Browse repository at this point
Copy the full SHA e7d6079View commit details -
Configuration menu - View commit details
-
Copy full SHA for f29d7b3 - Browse repository at this point
Copy the full SHA f29d7b3View commit details
Commits on Mar 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 20bf718 - Browse repository at this point
Copy the full SHA 20bf718View commit details
Commits on Mar 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 34cb8ef - Browse repository at this point
Copy the full SHA 34cb8efView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecc6b2c - Browse repository at this point
Copy the full SHA ecc6b2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ece6266 - Browse repository at this point
Copy the full SHA ece6266View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.