Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: SlackClient 로직 개선 및 로깅 추가 #637

Merged
merged 6 commits into from
Oct 20, 2022
Merged

refactor: SlackClient 로직 개선 및 로깅 추가 #637

merged 6 commits into from
Oct 20, 2022

Commits on Oct 19, 2022

  1. feat: 슬랙 API 예외 처리 중복 코드 제거

    @yeon-06
    yeon-06 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    9b17e05 View commit details
    Browse the repository at this point in the history

  2. feat: 슬랙 API 예외 로깅

    @yeon-06
    yeon-06 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    437ba96 View commit details
    Browse the repository at this point in the history

  3. refactor: request 값 로깅

    @yeon-06
    yeon-06 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b0fc135 View commit details
    Browse the repository at this point in the history

  4. refactor: 누락된 로직 재생성

    @yeon-06
    yeon-06 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    cc4def9 View commit details
    Browse the repository at this point in the history

  5. test: builder 대신 DTO를 이용해 모킹이 제대로 되지 않던 현상 개선

    @yeon-06
    yeon-06 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c280bd8 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' of https://github.com/woowacourse-teams/2022-p… 

    …ickpick into feature/refactor-SlackClient
    @yeon-06
    yeon-06 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d1d7c95 View commit details
    Browse the repository at this point in the history