[AN/USER] 디자인 수정 및 선택 업데이트 룰 추가 (#955) #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
re4rk
approved these changes
May 18, 2024
| @@ -122,4 +122,6 @@ | |||
| <string name="my_page_delete_account_alert_message">정말 탈퇴 하시겠습니까? 다시 되돌릴 수 없습니다.</string> | |||
| <string name="my_page_app_version_format">버전 : %s</string> | |||
|
|
|||
| <string name="tv_empty_stage">아직 라인업이\n공개되지 않았어요</string> | |||
There was a problem hiding this comment.
많은 곳에서 사용되서 tv로 시작한걸로 추측하는데 맞을까요??
There was a problem hiding this comment.
컨벤션 맞춰서 all 을 추가하겠습니다!
| @@ -23,6 +23,7 @@ class ArtistDetailFestivalViewHolder( | |||
| init { | |||
| binding.rvFestivalArtists.adapter = artistAdapter | |||
| binding.rvFestivalArtists.addItemDecoration(ArtistItemDecoration()) | |||
| binding.rvFestivalArtists.itemAnimator = null | |||
There was a problem hiding this comment.
itemAnimator를 null로 했을 때 차이점이 잘 모르겠는데 짧은 설명 부탁드려도될까요??
There was a problem hiding this comment.
기본 리사이클러뷰 애니메이션이 적용되어 있습니다.
뷰 껍대기를 재사용할 때 아티스트 목록이 변경되면서 부자연스럽게 움직이고있습니다. 그래서 모든 아티스트 목록에 애니메이션을 꺼주었습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
디자인 수정 사항
회의에서 나눴던 내용 아이템 너비를 match_parent 줘서 해결했습니다.
바텀 네비게이션 기본이 fade_In fade_out 인데 (제가 만든 커스텀 말고 기본 애니메이션입니다) 이걸 없앴습니다.
노션에 없는 디자인 변경사항
선택 업데이트 룰 추가
-> 2.1.0 으로 올라가면 2.0.X 는 선택 업데이트 대상이다.