Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 카테고리 UI 수정 #916

Merged
merged 5 commits into from
Oct 24, 2024
Merged

[FE] 카테고리 UI 수정 #916

merged 5 commits into from
Oct 24, 2024

Conversation

dle234
Copy link
Contributor

@dle234 dle234 commented Oct 24, 2024

연관된 이슈

구현한 기능

  • 카테고리 ui 수정
  • 선택 시 toast 메세지 뜨도록 수정
  • 회고리스트 '더보기'->'보기' 로 수정
  • 마이페이지 리스트 색 primary 로 수정

@dle234 dle234 self-assigned this Oct 24, 2024
@dle234 dle234 added 🧑‍💻 feat 신규 기능 개발 ⚙️ refactor 리팩터링 작업 labels Oct 24, 2024
@anttiey anttiey changed the title [FE] 카테고리 ui 수정 [FE] 카테고리 UI 수정 Oct 24, 2024
Copy link
Contributor

@greetings1012 greetings1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Comment on lines +51 to +55
export const CustomInputMessage = css`
top: 4rem;

font-size: 1rem;
`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 공통 컴포넌트로 관리되면 좋을 거 같아요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

별루

aria-atomic="true"
$height={height}
$status={status}
$css={$messageCss}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 나중에 리팩토링 해봅시다...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵!!!

@dle234 dle234 merged commit d355bb4 into FE/dev Oct 24, 2024
6 of 8 checks passed
@dle234 dle234 deleted the FE/feature/#915 branch October 24, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 feat 신규 기능 개발 ⚙️ refactor 리팩터링 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants