[BE] 회고 중복 생성 버그 수정 #938
Merged
[BE] 회고 중복 생성 버그 수정 #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddevilmidzy
approved these changes
Oct 30, 2024
Comment on lines
+78
to
+84
| @ExceptionHandler(RetrospectException.class) | ||
| public ResponseEntity<ApiErrorResponse> handleRetrospectException(final RetrospectException e) { | ||
| log.warn(e.getMessage()); | ||
|
|
||
| return ResponseEntity.status(RetrospectApiError.INVALID_RETROSPECT_REQUEST_ERROR.getHttpStatus()) | ||
| .body(new ApiErrorResponse(RetrospectApiError.INVALID_RETROSPECT_REQUEST_ERROR.getMessage())); | ||
| } |
There was a problem hiding this comment.
아 인마가 없어서 RetrospectException 상속해도 핸들러에서 안잡혔었군요.... 감샤합니당 수고하셨습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
상세 설명
회고 중복 생성 시
을 선택했습니다.
사실 백엔드단에서 기능을 새로 넣어야 할 부분은 없어서
Exception 네이밍 변경&ExceptionHandler에 없던 Exception 핸들링 추가만 해 주었습니다.회고 세부 문항 개수에 대한 Exception으로
InvalidRetrospectQuestionTypeException이 존재하는데,MaxRetrospectLimitException이 혼동되어 사용되고 있는 것 같아MaxRetrospectLimitException->DuplicateRetrospectException로 네이밍 변경하였습니다.에러 메세지도 "회고는 최대 6개까지 추가할 수 있습니다." -> "이미 회고가 작성되었습니다." 로 변경하였습니다.