Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALL] 작업 현황을 디스코드로 알림을 받기 위한 yml 파일 생성, 설정 #109

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[ALL] 작업 현황을 디스코드로 알림을 받기 위한 yml 파일 생성, 설정 #109

merged 2 commits into from
Jul 31, 2024

Conversation

hwinkr
Copy link
Contributor

@hwinkr hwinkr commented Jul 30, 2024

관련 이슈

작업 내용

  • 작업 현황
    • issue
    • pull-request
    • comment

들을 디스코드로 알림을 받을 수 있도록 설정했습니다.

특이 사항

리뷰 요구사항 (선택)

hw0603
hw0603 previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@hw0603 hw0603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

백엔드까지 같이 구현해주셨네요! 감사합니다👏

@hw0603 hw0603 added the ⚙️ 환경설정 환경을 설정해요 :) label Jul 30, 2024
@hw0603 hw0603 added this to the 3차 데모데이 milestone Jul 30, 2024
Largopie
Largopie previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Largopie Largopie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 저는 몇 시간동안 찾아봐서 적용했던 내용인데 굉장히 빠르게 잘 적용하셨네요... 👏👏👏

추가적으로, 머지되었을 때 전체 알림 설정도 팀원과 얘기해서 추가적으로 적용 하면 좋을 것 같네요!

ehBeak
ehBeak previously approved these changes Jul 30, 2024
View reviewed changes
Yoonkyoungme
Yoonkyoungme previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Yoonkyoungme Yoonkyoungme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해리~ 고생하셨습니다👏💯

@Yoonkyoungme Yoonkyoungme added 🐈 프론트엔드 프론트엔드 관련 이슈에요 :) 🐈‍⬛ 백엔드 백엔드 관련 이슈에요 :) labels Jul 30, 2024
seunghye218
seunghye218 reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@seunghye218 seunghye218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

트리거 되는 이벤트의 title을 통해 분기하는 것으로 이해했는데요. [FE]와 [BE]의 경우는 처리하지만 [ALL] 으로 만들어진 이슈나 PR의 경우는 어떻게 되는지 알 수 있을까요?

ikjo39
ikjo39 previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ikjo39 ikjo39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

seokmyungham
seokmyungham previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@seokmyungham seokmyungham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캬... 너무 눈부셔서 해리 얼굴이 안보입니다.. 👍
고생하셨어요

@hw0603 hw0603 assigned hw0603 and hwinkr and unassigned hw0603 Jul 30, 2024
@hwinkr
Copy link
Contributor Author

hwinkr commented Jul 30, 2024

고생하셨습니다! 저는 몇 시간동안 찾아봐서 적용했던 내용인데 굉장히 빠르게 잘 적용하셨네요... 👏👏👏

추가적으로, 머지되었을 때 전체 알림 설정도 팀원과 얘기해서 추가적으로 적용 하면 좋을 것 같네요!

머지되었을 때 전체 알림 설정도 이미 해놨어요~

ikjo39
ikjo39 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ikjo39 ikjo39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요 해리

hw0603
hw0603 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@hw0603 hw0603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많았어요!

@hwinkr hwinkr merged commit ded5a3f into develop Jul 31, 2024
4 checks passed
@hwinkr hwinkr deleted the feat/#108-discord-yml branch July 31, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghye218 seunghye218 seunghye218 left review comments

@Yoonkyoungme Yoonkyoungme Yoonkyoungme approved these changes

@seokmyungham seokmyungham seokmyungham approved these changes

@ehBeak ehBeak ehBeak approved these changes

@ikjo39 ikjo39 ikjo39 approved these changes

@hw0603 hw0603 hw0603 approved these changes

@Largopie Largopie Largopie left review comments

Assignees

@hwinkr hwinkr

Labels
⚙️ 환경설정 환경을 설정해요 :) 🐈 프론트엔드 프론트엔드 관련 이슈에요 :) 🐈‍⬛ 백엔드 백엔드 관련 이슈에요 :)
Projects
2024-momo
Status: Done
Milestone
3차 데모데이
Development

Successfully merging this pull request may close these issues.

[ALL] 작업 현황을 디스코드로 알림을 받을 수 있도록 yml 파일을 설정해요:)
8 participants
@hwinkr @hw0603 @ikjo39 @ehBeak @seunghye218 @seokmyungham @Yoonkyoungme @Largopie