-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] fix(SwaggerConfig): ForwardedHeaderFilter 추가 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 리버스 프록시 뒤에서 동작하는 swagger에서 https 스키마를 자동 인식하지 못하는 문제 수정
hw0603
requested review from
ehBeak,
ikjo39,
seokmyungham and
seunghye218
as code owners
July 30, 2024 05:42
Test Results47 tests 47 ✅ 4s ⏱️ Results for commit 3ecb8c3. ♻️ This comment has been updated with latest results. |
seokmyungham
previously approved these changes
Jul 30, 2024
ikjo39
approved these changes
Jul 30, 2024
seunghye218
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https로 인식이 잘 되겠네요 👍
ehBeak
approved these changes
Jul 30, 2024
seokmyungham
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
리버스 프록시 뒤에서 동작하는 Swagger에서 https 스키마를 자동 인식하지 못하는 문제를 해결했습니다.
자세한 내용은 이슈를 참조해 주세요!
특이 사항
SwaggerConfig.apiVersion
은 아직 불필요하다고 생각해서 제거했습니다.제거하면서 서브모듈에 저장된
yaml
프로퍼티 파일에도 변경사항이 있어요!CloudFront 배포 상에도 커스텀 헤더
X-Forwarded-Proto
를https
로 설정해 두었습니다.리뷰 요구사항 (선택)