[BE] 약속 잠금 해제 기능 추가 #127
Merged
[BE] 약속 잠금 해제 기능 추가 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikjo39
requested review from
ehBeak,
hw0603,
seokmyungham and
seunghye218
as code owners
Test Results65 tests 65 ✅ 4s ⏱️ Results for commit 64dfca4. ♻️ This comment has been updated with latest results. |
seunghye218
previously approved these changes
Jul 31, 2024
ehBeak
reviewed
Jul 31, 2024
Comment on lines
226
to
234
| AttendeeLoginRequest request = new AttendeeLoginRequest(attendee.name(), attendee.password()); | ||
|
|
||
| String token = RestAssured.given().log().all() | ||
| .contentType(ContentType.JSON) | ||
| .body(request) | ||
| .when().post("/api/v1/meetings/{uuid}/login", meeting.getUuid()) | ||
| .then().log().all() | ||
| .statusCode(HttpStatus.OK.value()) | ||
| .extract().jsonPath().getString("data.token"); |
There was a problem hiding this comment.
로그인을 요청하고 토큰을 얻는 로직이 각 테스트마다 중복해서 존재하네요..! 함수로 따로 분리해서 사용하면 어떨까요?👍
There was a problem hiding this comment.
배키 의견에 동의합니다! 관련 로직 메서드 분리하도록 할게요 :)
seunghye218
previously approved these changes
Aug 1, 2024
hw0603
requested changes
Aug 1, 2024
Comment on lines
90
to
93
| Meeting meeting = meetingRepository.findByUuid(uuid) | ||
| .orElseThrow(() -> new MomoException(MeetingErrorCode.NOT_FOUND_MEETING)); | ||
| Attendee attendee = attendeeRepository.findByIdAndMeeting(id, meeting) | ||
| .orElseThrow(() -> new MomoException(AttendeeErrorCode.NOT_FOUND_ATTENDEE)); |
There was a problem hiding this comment.
Enum 값을 보니 404를 내리는 것 같은데, 400이 더 적절할 것 같아요!
| .then().log().all() | ||
| .statusCode(HttpStatus.OK.value()) | ||
| .extract().jsonPath().getString("data.token"); | ||
| String token = getToken(attendee, meeting); |
| .statusCode(HttpStatus.OK.value()); | ||
| } | ||
|
|
||
| @DisplayName("존재하지 않는 약속을 잠금 해제 시도하면 404 Not Found를 반환한다.") |
There was a problem hiding this comment.
위에 언급한 것과 같이 400 Bad Request는 어떨까요?
ikjo39
dismissed stale reviews from ehBeak, seokmyungham, and seunghye218
via
64dfca4
seunghye218
approved these changes
Aug 1, 2024
hw0603
approved these changes
Aug 1, 2024
seokmyungham
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용