[FE] 약속 퍼널 패턴 인터페이스 통합 #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results9 tests 9 ✅ 11s ⏱️ Results for commit 4a52225. |
Largopie
approved these changes
Oct 9, 2024
Yoonkyoungme
approved these changes
Oct 9, 2024
| }; | ||
|
|
||
| const handleRangeStartDatePick = (date: string) => { | ||
| setRangeStartDate(date); | ||
| setRangeEndDate(null); | ||
| setSelectedDates([date]); | ||
| setSelectedDates(new Set([date])); |
There was a problem hiding this comment.
오예🤸♀️ Set 적극적으로 사용하는 모습 보기 좋군요! 음하하하하
ehBeak
pushed a commit
that referenced
this pull request
Oct 11, 2024
* refactor: 하나씩, 기간으로 날짜를 선택할 때 사용되는 커스텀 훅과 약속의 타입을 결정하는 커스텀 훅 추가 * refactor: 약속 선택 로직을 Set 자료구조를 사용하는 것으로 수정 * chore: 사용하지 않는 css 파일 삭제 * chore: 임시 약속 생성 페이지 삭제 * chore: 임시 약속 생성 페이지 컴포넌트 네이밍 수정 - 하나씩/기간으로 약속 날짜 선택, 약속 타입 결정 props 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
약속 퍼널 패턴을 실제로 서비스에서 활용할 수 있도록 인터페이스를 합쳤습니다.
낙타가 기존에 구현해 놨던 날짜만 선택하는 인터페이스와, 하나씩/기간으로 날짜를 선택하는 인터페이스를 통합했어요!
Screen.Recording.2024-10-08.at.22.15.37.mov
작업 내용
특이 사항
리뷰 요구사항 (선택)