-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ exclude blocked user comments #317
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,8 @@ | |
@Sql(value = "/data/comment.sql") | ||
class CommentControllerTest extends RestDocsSetting { | ||
|
||
private static final int COMMENT_COUNT_OF_FIRST_RECIPE = 3; | ||
|
||
@Test | ||
@WithLoginUser(email = "[email protected]") | ||
@DisplayName("레시피의 댓글을 조회한다.") | ||
|
@@ -48,7 +50,17 @@ void readComments() { | |
))) | ||
.when().get("/comments/{recipeId}", 1L) | ||
.then().log().all() | ||
.body("size()", is(2)); | ||
.body("size()", is(COMMENT_COUNT_OF_FIRST_RECIPE)); | ||
} | ||
|
||
@Test | ||
@WithLoginUser(email = "[email protected]") | ||
@DisplayName("레시피 댓글 조회 시 차단한 사용자의 댓글은 불러오지 않는다.") | ||
void readCommentWithBlockedUser() { | ||
RestAssured.given(spec).log().all() | ||
.when().get("/comments/{recipeId}", 1L) | ||
.then().log().all() | ||
.body("size()", is(COMMENT_COUNT_OF_FIRST_RECIPE - 1)); | ||
} | ||
|
||
@Test | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,12 +13,17 @@ TRUNCATE TABLE comment; | |
ALTER TABLE comment | ||
ALTER COLUMN id RESTART; | ||
|
||
TRUNCATE TABLE user_block; | ||
ALTER TABLE user_block | ||
ALTER COLUMN id RESTART; | ||
|
||
SET | ||
REFERENTIAL_INTEGRITY TRUE; | ||
|
||
INSERT INTO users (email, username, nickname, image, region) | ||
VALUES ('[email protected]', 'ela', '엘라', 'ela.jpg', 'KOREA'), | ||
('[email protected]', 'loki', '로키', 'loki.jpg', 'KOREA'); | ||
('[email protected]', 'loki', '로키', 'loki.jpg', 'KOREA'), | ||
('[email protected]', 'ato', '아토', 'ato.jpg', 'KOREA'); | ||
|
||
INSERT INTO recipe (title, author_id, cooking_time, thumbnail, difficulty, like_count, comment_count, description, created_at) | ||
VALUES ('김밥', 1, '01:00:00', '김밥이미지.jpg', 8, 1, 0, '김밥 조리법', '2024-07-02 13:00:00'), | ||
|
@@ -27,4 +32,8 @@ VALUES ('김밥', 1, '01:00:00', '김밥이미지.jpg', 8, 1, 0, '김밥 조리 | |
INSERT INTO comment (user_id, recipe_id, message, created_at) | ||
VALUES ('2', '1', 'great', '2024-01-01'), | ||
('1', '1', 'thank you','2024-01-02'), | ||
('2', '2', 'good', '2024-05-05'); | ||
('2', '2', 'good', '2024-05-05'), | ||
('3', '1', 'haha', '2024-01-03'); | ||
|
||
INSERT INTO user_block (blocker_id, blockee_id) | ||
values (2, 3); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상수로 빼니 가독성이 더 좋네요👍