✨ implement ingredient registration #78

tackyu · 2024-07-24T05:11:47Z

재료 등록

IngredientService의 register 메서드를 통해 재료 등록을 진행합니다.

Ingredient 등록
IngredientRecipe 등록
재료가 '대체 가능'한 상태라면 IngredientSubstitution 등록

검증

재료 이름 공백/null, 중복
개별 재료에 대한 대체 재료 이름 공백/null, 중복

github-actions · 2024-07-24T05:12:55Z

Overall Project	88.94% `-0.99%`	🍏
Files changed	95.05%	🍏

File	Coverage
IngredientRecipeService.java	100%	🍏
IngredientSubstitutionService.java	100%	🍏
IngredientCreateRequest.java	100%	🍏
IngredientService.java	91.03% `-8.97%`	🍏
Ingredient.java	80%	🍏
IngredientSubstitution.java	71.43%	🍏
IngredientRecipe.java	66.67%	🍏

HaiSeong

폰드! 코드리뷰 남겼습니다!

HaiSeong · 2024-07-24T05:41:36Z

backend/src/main/java/net/pengcook/ingredient/domain/Ingredient.java

 @Entity
+@NoArgsConstructor


옵션을 통해 접근 제어자를 private로 해보시

protected로 정정합니다

HaiSeong · 2024-07-24T05:44:28Z

backend/src/main/java/net/pengcook/ingredient/domain/Ingredient.java

+
+    public Ingredient(String name) {
+        this.name = name;
+    }


@AllArgumentConstructor 사용후 this(0L, ...) 으로 초기화 해도 좋을것 같아요.
Category 도메인 참고 해보시죠

HaiSeong · 2024-07-24T05:47:17Z

backend/src/main/java/net/pengcook/ingredient/domain/IngredientSubstitution.java

-import jakarta.persistence.Id;
-import jakarta.persistence.JoinColumn;
-import jakarta.persistence.ManyToOne;
+import jakarta.persistence.*;


혹시 우테코 스타일 적용되어있나요??
* 로 임포트로 변환 되는걸 처음봐서 스타일 적용되었는지 확인해주세요

구글 자바 컨벤션

3.3.1 No wildcard imports

Wildcard imports, static or otherwise, are not used.

HaiSeong · 2024-07-24T05:52:56Z

backend/src/main/java/net/pengcook/ingredient/dto/IngredientCreateRequest.java

+
+    private void validateName(String name) {
+        if (name == null || name.isBlank()) {
+            throw new IllegalArgumentException("name cannot be null or empty");


이제 커스텀 예외가 생겼으니 IngredientException 를 상속받아서 새로운 예외를 반환해주세요!

HaiSeong · 2024-07-24T06:02:18Z

backend/src/main/java/net/pengcook/ingredient/service/IngredientService.java

+        }
+    }
+
+    private Ingredient registerIngredient(String ingredientName) {


있으면 조회해서 가져오는 분기도 있는데 메서드명을 보면 "재료를 저장한다." 라는 의미밖에 없네요.
registerOrGetIngredient 는 어떤가요?

HaiSeong · 2024-07-24T06:20:16Z

backend/src/main/java/net/pengcook/ingredient/repository/IngredientRepository.java

+
+    boolean existsByName(String name);
+
+    Ingredient findByName(String name);


findByName 과 getByName 의 차이를 공부해보면 알아보면 좋을것 같아요.

저도 User 쪽 가서 수정해야겠네요.

find : 찾아본다. (있을 수도 있고 없을수도 있음. 없어도 예외 x, Optional로 반환이 일반적)

get : 가져온다. (있어야 한다. 없으면 예외)

HaiSeong · 2024-07-24T06:25:00Z

backend/src/main/java/net/pengcook/ingredient/service/IngredientService.java

+            return ingredientRepository.findByName(name);
+        }
+
+        return ingredientRepository.save(new Ingredient(name));


카테고리 코드쪽에 좋은 로직이 있어서 참고해보시면 좋을것 같아요

Category category = categoryRepository.findByName(name) .orElseGet(() -> categoryRepository.save(new Category(name)));

HaiSeong · 2024-07-24T06:30:17Z

backend/src/main/java/net/pengcook/ingredient/service/IngredientService.java

+    private void registerSubstitution(IngredientCreateRequest request, IngredientRecipe ingredientRecipe) {
+        List<String> substitutionNames = request.substitutions();
+        validateDuplicateNames(substitutionNames);
+


registerSubstitution 메서드와 registerIngredientSubstitution 이 메서드를 private 보다 IngredientRecipeService와 IngredientSubstitutionService의 public 메서드로 해보는것은 어떨까요?

IngredientSubstitution을 저장하는것은 IngredientSubstitutionService의 책임인데 이걸 IngredientService가 대신 해주고 있는것 같아요.

또한 Private 메서드라 테스트가 어려워요.

HaiSeong · 2024-07-24T06:35:06Z

backend/src/test/java/net/pengcook/ingredient/service/IngredientServiceTest.java

+    @BeforeEach
+    void setUp() {
+        User author = userRepository.findById(1L).get();
+        Recipe recipe = new Recipe(


ingredient.sql에 레시피 정보를 저장하면 불필요한 레포지토리 의존을 줄일 수 있을것 같아요.

HaiSeong · 2024-07-24T06:38:09Z

backend/src/test/java/net/pengcook/ingredient/service/IngredientServiceTest.java

+    }
+
+    @Test
+    @DisplayName("재료 등록")


테스트 디스플레이 네임을 컨벤션에 맞춰주세요

github-actions · 2024-07-25T02:05:46Z

Overall Project	90.25% `-0.6%`	🍏
Files changed	97.14%	🍏

File	Coverage
InvalidNameException.java	100%	🍏
IngredientRecipeService.java	100%	🍏
IngredientSubstitutionService.java	100%	🍏
IngredientCreateRequest.java	100%	🍏
IngredientService.java	94.23% `-5.77%`	🍏
Ingredient.java	86.96%	🍏
IngredientSubstitution.java	80%	🍏
IngredientRecipe.java	75.68%	🍏

HaiSeong

어제 고생 많았습니다!! 수고했습니다!

hyxrxn

잘 읽었습니다~~~
대체재료 때문에 꽤나 힘드셨겠어요
고생하셨습니다

hyxrxn · 2024-07-25T01:34:21Z

backend/src/main/java/net/pengcook/ingredient/domain/IngredientSubstitution.java

-import jakarta.persistence.Id;
-import jakarta.persistence.JoinColumn;
-import jakarta.persistence.ManyToOne;
+import jakarta.persistence.*;


구글 자바 컨벤션

3.3.1 No wildcard imports

Wildcard imports, static or otherwise, are not used.

hyxrxn · 2024-07-25T01:59:11Z

backend/src/main/java/net/pengcook/ingredient/repository/IngredientRecipeRepository.java

+
+import net.pengcook.ingredient.domain.IngredientRecipe;
+
+@Repository


이거 어노테이션 없어도 된대요
JpaRepository면 Spring Data JPA가 알아서 구현체를 주입해준다고 하네요!

hyxrxn · 2024-07-25T02:18:57Z

backend/src/test/java/net/pengcook/ingredient/dto/IngredientCreateRequestTest.java

+            "''",
+            "' '",
+    })
+    @DisplayName("재료 이름에 공백 또는 null은 허용하지 않는다.")


✅ 테스트 코드 네이밍

DisplayName은 꼭 사용해요.

DisplayName

성공

{행위}가 된다.

실패

{상황}에 {행위}를 하면 예외가 발생한다.

재료 이름에 공백 또는 null이 입력되면 예외가 발생한다.
어떨지요

hyxrxn · 2024-07-25T02:23:14Z

backend/src/main/java/net/pengcook/ingredient/service/IngredientService.java

+    private void registerIngredientSubstitution(IngredientRecipe ingredientRecipe, Ingredient substitution) {
+        ingredientSubstitutionService.save(ingredientRecipe, substitution);
+    }


이 메서드가... 꼭 필요한가요....???
정말 몰라서 물어보는 겁니다!!!

가독성을 위해 생성하였습니다.
꼭 필요하진 않습니다!🥲

github-actions · 2024-07-25T04:43:30Z

Overall Project	90.25% `-0.6%`	🍏
Files changed	97.14%	🍏

File	Coverage
InvalidNameException.java	100%	🍏
IngredientRecipeService.java	100%	🍏
IngredientSubstitutionService.java	100%	🍏
IngredientCreateRequest.java	100%	🍏
IngredientService.java	94.23% `-5.77%`	🍏
Ingredient.java	86.96%	🍏
IngredientSubstitution.java	80%	🍏
IngredientRecipe.java	75.68%	🍏

github-actions · 2024-07-25T05:35:49Z

Overall Project	89.63% `-0.57%`	🍏
Files changed	97.14%	🍏

File	Coverage
InvalidNameException.java	100%	🍏
IngredientRecipeService.java	100%	🍏
IngredientSubstitutionService.java	100%	🍏
IngredientCreateRequest.java	100%	🍏
IngredientService.java	94.23% `-5.77%`	🍏
Ingredient.java	86.96%	🍏
IngredientSubstitution.java	80%	🍏
IngredientRecipe.java	75.68%	🍏

tackyu added 7 commits July 24, 2024 10:59

♻️ add getter method in domain class

2eb269b

✨ create request DTO for ingredient

33bbf53

✅ add test for IngredientCreateRequest

d15ab42

✨ implement register method for ingredient

3ef41a0

✅ add test for IngredientService

273dfc0

♻️ inline method to simplify code

9fe985d

Merge remote-tracking branch 'origin/be/dev' into be/feat/24

7d5a4f9

tackyu requested review from HaiSeong and hyxrxn July 24, 2024 05:11

tackyu temporarily deployed to test July 24, 2024 05:11 — with GitHub Actions Inactive

tackyu added ✨ feature new feature BE Backend labels Jul 24, 2024

tackyu self-assigned this Jul 24, 2024

HaiSeong requested changes Jul 24, 2024

View reviewed changes

tackyu added 8 commits July 24, 2024 17:00

Merge remote-tracking branch 'origin/be/dev' into be/feat/24

ccf192e

Merge remote-tracking branch 'origin/be/dev' into be/feat/24

635ffd2

♻️ change access modifier of constructor

ee69b11

♻️ simplify registerOrGetIngredient method

2a21e11

♻️ use custom exception for ingredient

2779356

♻️ add test data of recipe

44aadea

♻️ refactor for readability

67627e2

♻️ refactor for code convention

8a99729

tackyu temporarily deployed to test July 25, 2024 02:04 — with GitHub Actions Inactive

tackyu requested a review from HaiSeong July 25, 2024 02:06

HaiSeong approved these changes Jul 25, 2024

View reviewed changes

hyxrxn approved these changes Jul 25, 2024

View reviewed changes

tackyu added 2 commits July 25, 2024 13:35

♻️ eliminate unnecessary annotation

63da917

♻️ refactor for code convention

29ca71f

tackyu temporarily deployed to test July 25, 2024 04:42 — with GitHub Actions Inactive

Merge remote-tracking branch 'origin/be/dev' into be/feat/24

3576f2a

tackyu temporarily deployed to test July 25, 2024 05:34 — with GitHub Actions Inactive

tackyu merged commit cca2971 into be/dev Jul 25, 2024
1 check passed

tackyu deleted the be/feat/24 branch July 25, 2024 05:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ implement ingredient registration #78

✨ implement ingredient registration #78

tackyu commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

HaiSeong left a comment

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

hyxrxn Jul 25, 2024

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

HaiSeong Jul 24, 2024

github-actions bot commented Jul 25, 2024

HaiSeong left a comment

hyxrxn left a comment

hyxrxn Jul 25, 2024

hyxrxn Jul 25, 2024

hyxrxn Jul 25, 2024

hyxrxn Jul 25, 2024

tackyu Jul 25, 2024

github-actions bot commented Jul 25, 2024

github-actions bot commented Jul 25, 2024


		boolean existsByName(String name);

		Ingredient findByName(String name);


		import net.pengcook.ingredient.domain.IngredientRecipe;

		@Repository

		@Entity
		@NoArgsConstructor

✨ implement ingredient registration #78

✨ implement ingredient registration #78

Conversation

tackyu commented Jul 24, 2024

재료 등록

검증

github-actions bot commented Jul 24, 2024

HaiSeong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 25, 2024

HaiSeong left a comment

Choose a reason for hiding this comment

hyxrxn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

✅ 테스트 코드 네이밍

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 25, 2024

github-actions bot commented Jul 25, 2024