-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - 여행 계획 등록 페이지 접근성 개선 #554
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
00ec4aa
feat(TextField): 필수 항목이면 '필수 항목입니다'를 접근성 리더기가 읽어주는 기능 구현
jinyoung234 621747c
feat(TravelPlanRegisterPage): input을 enter 했을 때 캘린더가 열리는 것 구현
jinyoung234 97176b3
feat(TravelPlanRegisterPage): 캘린더가 열리고 닫힐 때 안내 메시지 추가
jinyoung234 cab03c8
feat(Calendar): 캘린더 이전, 이후 버튼 눌렀을 때 안내메시지 추가
jinyoung234 947d2f2
feat(Calendar): 캘린더 내 각 일을 선택 가능하도록 접근성 개선
jinyoung234 79e3c7e
feat(AccordionTrigger): 아코디언 버튼을 눌렀을 때 열림, 닫힘 상태 메시지 제공
jinyoung234 f237e65
feat(GoogleSearchPopup): 팝업이 열렸을 때 input이 포커스 간 후 접근성 메시지를 읽는 것 구현
jinyoung234 e075b6e
fix(GoogleSearchPopup): 자동완성 장소 항목을 엔터 했을 경우 런타임 에러 발생하는 부분 해결
jinyoung234 5a354ef
refactor(GoogleSearchPopup): 팝업 열렸을 때 다른 요소들이 스크린 리더기가 접근하지 못하도록 개선
jinyoung234 8e46fe5
refactor(AccordionTrigger): 아코디언 버튼 aria-label 추가
jinyoung234 80ee5cc
feat(PlaceTodoListItem): todo 삭제 버튼 aria-label 추가
jinyoung234 5541d25
feat: 등록 바텀 시트 등장할 때 focus trap 적용
jinyoung234 9eee3cb
fix: 전체 화면 탭이 적용되지 않는 문제 해결
jinyoung234 289f3a1
Merge branch 'develop/fe' into feature/fe/#538
jinyoung234 985cd7c
Merge branch 'develop/fe' into feature/fe/#538
jinyoung234 2f0a396
fix: ci 문제 해결
jinyoung234 860512c
Merge branch 'develop/fe' into feature/fe/#538
jinyoung234 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,3 +80,16 @@ export const WeekRow = styled.tr` | |
export const boldTextStyle = css` | ||
font-weight: 700; | ||
`; | ||
|
||
export const visualHiddenStyle = css` | ||
overflow: hidden; | ||
position: absolute; | ||
width: 1px; | ||
height: 1px; | ||
margin: -1px; | ||
padding: 0; | ||
border: 0; | ||
|
||
white-space: nowrap; | ||
clip: rect(0, 0, 0, 0); | ||
`; | ||
Comment on lines
+83
to
+95
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기도요! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,3 +30,16 @@ export const TextContainer = styled.div` | |
export const symbolStyle = css` | ||
color: ${theme.colors.text.required}; | ||
`; | ||
|
||
export const visualHiddenStyle = css` | ||
overflow: hidden; | ||
position: absolute; | ||
width: 1px; | ||
height: 1px; | ||
margin: -1px; | ||
padding: 0; | ||
border: 0; | ||
|
||
white-space: nowrap; | ||
clip: rect(0, 0, 0, 0); | ||
`; | ||
Comment on lines
+34
to
+45
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 부분도요! |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 리버가 VisualHidden 컴포넌트를 구현했더라고요 이후에 합치면 좋을 거 같아요!