[Feature] - 검색 결과 페이지 내 필터링 옵션 적용 #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useInfiniteTravelogues 내에서 검색 조건 까지 모두 처리하는 것으로 변경
Test Results11 tests 11 ✅ 14s ⏱️ Results for commit f3ceaec. ♻️ This comment has been updated with latest results. |
simorimi
approved these changes
Oct 23, 2024
| singleSelectionAnimationKey, | ||
| resetSingleSelectionTags, | ||
| increaseSingleSelectionAnimationKey, | ||
| } = useSingleSelectionTag(STORAGE_KEYS_MAP.mainPageSort, STORAGE_KEYS_MAP.mainPageTravelPeriod); |
There was a problem hiding this comment.
storage key를 다르게 써야하지 않을까라는 생각이 듭니다! 왜냐하면 search 페이지에서 표시한 테그들이 메인에도 남아있으면 사용자 입장에서 당황스러울 거 같아서요 지니의 생각은 어떤가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
📸 스크린샷
X
🙈 참고 사항