feat: Filter block types with allow list #113
Open
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
To improve stability, the remote, site-specific editor un-registers block types that are not on the allow list.
This is largely in place for development experience purposes, not user facing. It allows the editor WebView to reload and retains its current GBKit global.
dcalhoun
force-pushed
the
feat/block-types-allow-list
branch
from
7838da1 to
38fe2c7
Compare
dcalhoun
commented
Apr 5, 2025
Comment on lines
+241
to
+247
| if ( ! window.GBKit ) { | ||
| try { | ||
| window.GBKit = JSON.parse( | ||
| localStorage.getItem( 'GBKit' ) | ||
| ); | ||
| } catch ( error ) {} | ||
| } |
There was a problem hiding this comment.
This ensures that page reloads occurring in a development environment continue to work. This should have no impact on users.
Avoid exceptions invoking array methods on `undefined`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Filter the available block types via an allow list fetched from the API
endpoint.
Why?
Fix CMM-224. Used for selectively enabling stable block types and/or removing
unnecessary or problematic assets.
How?
Given block types are registered via the scripts loaded onto the page, we must
unregister each block type not within the allow list.
Testing Instructions
This small, conditional-wrapped change is likely safe to merge without additional testing. For posterity, the following are the explicit steps for testing:
Important
Testing this currently requires completing the testing instructions setup for Automattic/jetpack#42835 to your sandbox server and routing your testing device
public-api.wordpress.comtraffic to your sandbox server.Experimental block editor pluginsfeature flag.Accessibility Testing Instructions
N/A, no navigation changes.
Screenshots or screencast
N/A, no visual changes.